From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id F12018E5D
 for <dev@dpdk.org>; Thu, 29 Oct 2015 10:38:35 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP; 29 Oct 2015 02:38:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,213,1444719600"; d="scan'208";a="838277425"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63])
 by fmsmga002.fm.intel.com with SMTP; 29 Oct 2015 02:38:32 -0700
Received: by  (sSMTP sendmail emulation); Thu, 29 Oct 2015 09:38:31 +0025
Date: Thu, 29 Oct 2015 09:38:31 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Helin Zhang <helin.zhang@intel.com>
Message-ID: <20151029093831.GA6160@bricha3-MOBL3>
References: <1446091744-16758-1-git-send-email-helin.zhang@intel.com>
 <1446098572-4409-1-git-send-email-helin.zhang@intel.com>
 <1446098572-4409-2-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446098572-4409-2-git-send-email-helin.zhang@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Oct 2015 09:38:36 -0000

On Thu, Oct 29, 2015 at 02:02:50PM +0800, Helin Zhang wrote:
> The default input set of fields of a received packet are loaded from
> firmware, which cannot be modified even users want to use different
> fields for RSS or flow director. Here adds more flexibilities of
> selecting packet fields for hash calculation or flow director for
> users.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> Signed-off-by: Andrey Chilikin <andrey.chilikin@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c  | 742 ++++++++++++++++++++++++++++++++++++++++
>  drivers/net/i40e/i40e_ethdev.h  |   7 +
>  drivers/net/i40e/i40e_fdir.c    |  31 ++
>  lib/librte_ether/rte_eth_ctrl.h | 114 +++++-
>  4 files changed, 890 insertions(+), 4 deletions(-)
> 
<snip>
> @@ -672,6 +776,8 @@ struct rte_eth_hash_filter_info {
>  		uint8_t enable;
>  		/** Global configurations of hash filter */
>  		struct rte_eth_hash_global_conf global_conf;
> +		/** Global configurations of hash filter input set */
> +		struct rte_eth_input_set_conf input_set_conf;
>  	} info;
>  };
>
Hi Helin,

Just to check: Does this change affect the size of the structure and cause ABI
issues?

/Bruce