DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper
Date: Thu, 29 Oct 2015 13:24:31 +0000	[thread overview]
Message-ID: <20151029132430.GA13416@bricha3-MOBL3> (raw)
In-Reply-To: <3011581.XzQahXhfO1@xps13>

On Thu, Oct 29, 2015 at 02:03:59PM +0100, Thomas Monjalon wrote:
> 2015-10-29 13:33, David Marchand:
> > On Fri, Oct 23, 2015 at 5:53 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> > wrote:
> > 
> > > +for p in "$@" ; do
> > > +       printf -- "\n### $p\n\n"
> > > +       report=$($DPDK_CHECKPATCH_PATH $options "$p" 2>/dev/null)
> > > +       [ $? -ne 0 ] || continue
> > > +       printf '%s\n' "$report" | head -n -6
> > > +       status=$(($status + 1))
> > > +done
> > > +exit $status
> > >
> > 
> > I prefer when checking scripts only complain when something is wrong :-)
> > So I would only display the file name if checkpatch complains.
> 
> Yes I'll move the first printf after the "continue".

Ok, but perhaps instead we can get a print at the end of how many files were
checked. I'm concerned about the case where we think we have checked something and
it's ok, when in fact we have actually had an error in our command and e.g. not checked
any files at all. The printing of the filename helps give a guarantee that the
script is doing the right thing, so if it goes away, I'd hope for some other method
to ensure that.

/Bruce

  reply	other threads:[~2015-10-29 13:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 15:53 [dpdk-dev] [PATCH 0/2] more basic tests Thomas Monjalon
2015-10-23 15:53 ` [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-10-23 16:03   ` Stephen Hemminger
2015-10-23 16:34     ` Thomas Monjalon
2015-10-23 16:56       ` Stephen Hemminger
2015-10-23 16:58       ` Stephen Hemminger
2015-10-23 20:27         ` Thomas Monjalon
2015-10-29 12:17   ` Bruce Richardson
2015-10-29 12:33   ` David Marchand
2015-10-29 13:03     ` Thomas Monjalon
2015-10-29 13:24       ` Bruce Richardson [this message]
2015-10-29 13:34         ` Thomas Monjalon
2015-10-29 13:48           ` Bruce Richardson
2015-10-29 13:54             ` David Marchand
2015-10-29 13:57               ` Thomas Monjalon
2015-10-30 16:16                 ` Bruce Richardson
2015-10-30 16:23                   ` Thomas Monjalon
2015-11-02 10:28                     ` Van Haaren, Harry
2015-11-02 10:33                       ` Bruce Richardson
2015-10-23 15:53 ` [dpdk-dev] [PATCH 2/2] scripts: add build tests Thomas Monjalon
2015-11-23  1:40 ` [dpdk-dev] [PATCH v2 0/2] more basic tests Thomas Monjalon
2015-11-23  1:40   ` [dpdk-dev] [PATCH v2 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-11-24 16:33     ` Bruce Richardson
2015-11-23  1:40   ` [dpdk-dev] [PATCH v2 2/2] scripts: add build tests Thomas Monjalon
2015-11-24 17:49     ` Mcnamara, John
2015-11-24 18:14       ` Thomas Monjalon
2015-12-03 17:39   ` [dpdk-dev] [PATCH v2 0/2] more basic tests Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151029132430.GA13416@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).