From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A058291BF
 for <dev@dpdk.org>; Fri, 30 Oct 2015 15:24:29 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga102.fm.intel.com with ESMTP; 30 Oct 2015 07:24:29 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,218,1444719600"; d="scan'208";a="823175284"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63])
 by fmsmga001.fm.intel.com with SMTP; 30 Oct 2015 07:24:26 -0700
Received: by  (sSMTP sendmail emulation); Fri, 30 Oct 2015 14:24:25 +0025
Date: Fri, 30 Oct 2015 14:24:25 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Message-ID: <20151030142425.GC10520@bricha3-MOBL3>
References: <1446210879-14242-1-git-send-email-jijiang.liu@intel.com>
 <1446210879-14242-3-git-send-email-jijiang.liu@intel.com>
 <20151030142227.GB10520@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151030142227.GB10520@bricha3-MOBL3>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue
 of valid_group in the delete_depth_small()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Oct 2015 14:24:30 -0000

On Fri, Oct 30, 2015 at 02:22:27PM +0000, Bruce Richardson wrote:
> On Fri, Oct 30, 2015 at 09:14:39PM +0800, Jijiang Liu wrote:
> 
> Title can be shortened to: "lpm: fix initialization of valid_group field"
> 
> > Fixes an initialization issue of 'valid_group' in the delete_depth_small function.
> > 
> > In this function, use new rte_lpm_tbl8_entry we call A to replace the old rte_lpm_tbl8_entry. But the valid_group do not set VALID, so it 
> > will be INVALID.
> > 
> > Then when adding a new route which depth is > 24,the tbl8_alloc() function will search the rte_lpm_tbl8_entrys to find INVALID 
> > valid_group, and it will return the A to the add_depth_big function, so A's data is overridden.
> > 
> 
> Not sure this message is entirely clear.
> How about:
>   When adding an entry to a tbl8, the .valid_group field should always be set,
>   so that future adds do not accidently find and use this table, thinking it is
>   currently invalid, i.e. unused, and thereby overwrite existing entries.
> 
> > Signed-off-by: NaNa <nana.nn@alibaba-inc.com>
> > 
Assuming we get a little cleanup on commit title and log message (Thomas, perhaps
just a rewrite on commit?):

Acked-by: Bruce Richardson <bruce.richardson@intel.com>