[dpdk-dev] [PATCH] tools/dpdk_nic_bind.py: alias -s to --summary

[dpdk-dev] [PATCH] tools/dpdk_nic_bind.py: alias -s to --summary

[Harry van Haaren]

This patch adds -s as an alias to --summary in dpdk_nic_bind.py,
providing a convienient shorthand.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
 tools/dpdk_nic_bind.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index b7bd877..64f61d1 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -68,7 +68,7 @@ Options:
     --help, --usage:
         Display usage information and quit
 
-    --status:
+    -s, --status:
         Print the current status of all known network interfaces.
         For each device, it displays the PCI domain, bus, slot and function,
         along with a text description of the device. Depending upon whether the
@@ -477,7 +477,7 @@ def parse_args():
         sys.exit(0)
 
     try:
-        opts, args = getopt.getopt(sys.argv[1:], "b:u",
+        opts, args = getopt.getopt(sys.argv[1:], "b:u:s",
                                ["help", "usage", "status", "force",
                                 "bind=", "unbind"])
     except getopt.GetoptError, error:
@@ -489,7 +489,7 @@ def parse_args():
         if opt == "--help" or opt == "--usage":
             usage()
             sys.exit(0)
-        if opt == "--status":
+        if opt == "--status" or opt == "-s":
             status_flag = True
         if opt == "--force":
             force_flag = True
-- 
1.9.1

Re: [dpdk-dev] [PATCH] tools/dpdk_nic_bind.py: alias -s to --summary

[Panu Matilainen]

On 10/30/2015 02:09 PM, Harry van Haaren wrote:
> This patch adds -s as an alias to --summary in dpdk_nic_bind.py,
> providing a convienient shorthand.

The patch is about adding an alias to --status, but the summary talks 
about --summary. And I nearly did the same when writing this :)

	- Panu -

[dpdk-dev] [PATCH v2] tools/dpdk_nic_bind.py: alias -s to --status

[Harry van Haaren]

This patch adds -s as an alias to --status in dpdk_nic_bind.py,
providing a convienient shorthand.

v2:
- Corrected --summary to --status
- Fixed bug regarding -u usage (Thanks Ferruh Yigit for suggested fix)

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
 tools/dpdk_nic_bind.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index b7bd877..f02454e 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -68,7 +68,7 @@ Options:
     --help, --usage:
         Display usage information and quit
 
-    --status:
+    -s, --status:
         Print the current status of all known network interfaces.
         For each device, it displays the PCI domain, bus, slot and function,
         along with a text description of the device. Depending upon whether the
@@ -477,7 +477,7 @@ def parse_args():
         sys.exit(0)
 
     try:
-        opts, args = getopt.getopt(sys.argv[1:], "b:u",
+        opts, args = getopt.getopt(sys.argv[1:], "b:us",
                                ["help", "usage", "status", "force",
                                 "bind=", "unbind"])
     except getopt.GetoptError, error:
@@ -489,7 +489,7 @@ def parse_args():
         if opt == "--help" or opt == "--usage":
             usage()
             sys.exit(0)
-        if opt == "--status":
+        if opt == "--status" or opt == "-s":
             status_flag = True
         if opt == "--force":
             force_flag = True
-- 
1.9.1

Re: [dpdk-dev] [PATCH v2] tools/dpdk_nic_bind.py: alias -s to --status

[Ferruh Yigit]

On Fri, Oct 30, 2015 at 02:17:58PM +0000, Harry van Haaren wrote:
> This patch adds -s as an alias to --status in dpdk_nic_bind.py,
> providing a convienient shorthand.
> 
> v2:
> - Corrected --summary to --status
> - Fixed bug regarding -u usage (Thanks Ferruh Yigit for suggested fix)
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH v2] tools/dpdk_nic_bind.py: alias -s to --status

[Thomas Monjalon]

2015-10-30 16:37, Ferruh Yigit:
> On Fri, Oct 30, 2015 at 02:17:58PM +0000, Harry van Haaren wrote:
> > This patch adds -s as an alias to --status in dpdk_nic_bind.py,
> > providing a convienient shorthand.
> > 
> > v2:
> > - Corrected --summary to --status
> > - Fixed bug regarding -u usage (Thanks Ferruh Yigit for suggested fix)
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks