From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16])
 by dpdk.org (Postfix) with ESMTP id 20B455A64
 for <dev@dpdk.org>; Mon,  2 Nov 2015 16:15:00 +0100 (CET)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3nqHq7658qzBjL;
 Mon,  2 Nov 2015 16:14:59 +0100 (CET)
Date: Mon, 2 Nov 2015 16:13:18 +0100
From: Jan Viktorin <viktorin@rehivetech.com>
To: "Hunt, David" <david.hunt@intel.com>
Message-ID: <20151102161318.66989bb9@pcviktorin.fit.vutbr.cz>
In-Reply-To: <56377B6E.70502@intel.com>
References: <1446212826-19425-7-git-send-email-david.hunt@intel.com>
 <5633798B.2050708@intel.com>
 <20151030161106.4657232.16920.465@rehivetech.com>
 <56339AA9.1060505@intel.com>
 <20151102063209.GC17659@localhost.localdomain>
 <56373F59.6080602@intel.com>
 <20151102131710.GA10385@localhost.localdomain>
 <56377B6E.70502@intel.com>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 6/6] test: add checks for cpu flags on
 armv8
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 15:15:00 -0000

On Mon, 2 Nov 2015 15:04:14 +0000
"Hunt, David" <david.hunt@intel.com> wrote:

> On 02/11/2015 13:17, Jerin Jacob wrote:
> -snip--
> > If am not wrong existing  rte_cpu_get_flag_enabled() implementation
> > should be broken in your platform also for arm64. as I could see only AT_HWCAP
> > not AT_HWCAP2 and AT_HWCAP is 0x7 that means your platform also
> > follows
> >
> > http://lxr.free-electrons.com/source/arch/arm64/include/uapi/asm/hwcap.h
> >
> > and the implmentation is
> >
> > FEAT_DEF(SWP,       0x00000001, 0, REG_HWCAP,  0) // not correct for arm64
> > FEAT_DEF(HALF,      0x00000001, 0, REG_HWCAP,  1) // not correct for arm64
> > FEAT_DEF(THUMB,     0x00000001, 0, REG_HWCAP,  2) // not correct for arm64
> > FEAT_DEF(A26BIT,    0x00000001, 0, REG_HWCAP,  3)  
> --snip--
> > FEAT_DEF(CRC32,     0x00000001, 0, REG_HWCAP2,  4)
> > FEAT_DEF(AARCH32,   0x00000001, 0, REG_PLATFORM, 0)
> > FEAT_DEF(AARCH64,   0x00000001, 0, REG_PLATFORM, 1)
> >
> > Am I missing something ?  
> 
> You are correct. I need to re-visit this. In merging the ARMv7 and 
> ARVv8, I should have split the hardware capabilities flags into 32-but 
> and 64-bit versions. I'll do that in the next patch.
> Thanks,
> Dave.

Should I split the rte_atomic.h and rte_cpuflags.h then?

Jan

> 
> 
> 
> 
> 



-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic