From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bn0100.outbound.protection.outlook.com [157.56.110.100]) by dpdk.org (Postfix) with ESMTP id 33613378E for ; Mon, 2 Nov 2015 17:20:17 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (122.167.52.198) by CY1PR0701MB1980.namprd07.prod.outlook.com (10.163.141.22) with Microsoft SMTP Server (TLS) id 15.1.312.18; Mon, 2 Nov 2015 16:20:13 +0000 Date: Mon, 2 Nov 2015 21:49:54 +0530 From: Jerin Jacob To: Jan Viktorin Message-ID: <20151102161954.GB1869@localhost.localdomain> References: <1446473921-12706-1-git-send-email-jerin.jacob@caviumnetworks.com> <1446473921-12706-2-git-send-email-jerin.jacob@caviumnetworks.com> <1446473921-12706-3-git-send-email-jerin.jacob@caviumnetworks.com> <20151102163937.296ef169@pcviktorin.fit.vutbr.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151102163937.296ef169@pcviktorin.fit.vutbr.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.52.198] X-ClientProxiedBy: MAXPR01CA0041.INDPRD01.PROD.OUTLOOK.COM (25.164.146.141) To CY1PR0701MB1980.namprd07.prod.outlook.com (25.163.141.22) X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1980; 2:6jGAVoEP2DMwXljTxHTP5qwNMbzS/7wVsGo+t3kIsybzScJzdIhaOZHgeG/yeP+0zIRYLQvqZ1stYOlQGaPwKutsWgIoKS0kHCFpn5ngDVDY9t7uFG0bBo154QrMeQmPLDNfqWOMUIPmW9+vGAawx8fSKCGP3Qc8z1g37+77S/0=; 3:3LVc8Pe/27Y4KTC3ZzEFwLzvTjaWqz8zyNVb4fYvDIFHbjnnmVKhf74MqgKU7YFzArOGXBWL/YoHLsNCSgHGKL5sdRT5e2ZZ7NC+qDDlRMnQa6hc8vQs7SDoSQ3HGimzM8IKWDa1qzY8tR6/OfkqQQ==; 25:w+yPwwKWXufPhslX+lsb2jjy4QH/qQAD1YsoYtkz02Bxwsaq33E0pk/mBSPt6GmHXRvXwlgS7SZg/CUtTwoXXgIm19m4gCvF2OamZBZz6PBqcMTAoeD3AM/sd8m9AJq9g825/LABxAPTRmg4QK4DX0o48776TRCS4hvyjcMIQD6Pbfhj2FudH4EGmRgvTUtJMW8sBu4I/4ly4tDAx2QcmzYiKFkhnsOcM3ewb0bQNpo7EFIiOC71o3qe/6stiV0XnJBG9JoidLIDDxdtUMeuEw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1980; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1980; 20:pbibxTBDgn1RQjvK89kjR2sG2MGapb7tnbW8XdwaA+4pxOhYeJm+/ADwhorwWPXBZ5NpOu0qvDf+8NBMEaxhDtOYP134NxQko1DdflTBgaf3veR+u9ysstd6DSrvR1OrCLS619NnqYOQHzJpeERSGIsNwR1c20t+rvjFTT7FCcS0qH61rpx+RS0uAd22Vs1d0srfEOV4d5fF0e50MROn6QdgZVYxeOJPMjlYJp3USHHXUhVenP5+8/o4cTEnuBfAlOqjRR7Ovkvz+8CVXkQt39HiDMMELwj4k+F5cLvAknWKZ1OWx0R6Y+ZVpmFoefxvueEa1J3Y1ancDv9T19cF6X2s/F2YHAZlWNn1cFq7YAE3L6v/3tMxt9lDXqOu77q666ypZB0b5N+hfrjtEnYAiRzzocx4UtQXPu02F+oGe1KdQFx7xiCefnEJog0/RrlZWOEKkafLYpupMWuLlAcEuwJ/uGjMfmb5OsA6lMsjfqA7S7BF8GdquVDJxLwli2L11nYrDbdrjHPmi6+vLTEzrKWN43B/PzuMI/OVhUGmrvuMspPljMtZ9Ck8YYJ1jFgZaVc6sDG+6nbEV3eGxypCCXeQqsjdt5+vEMJu92S9MiI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236414709691187); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046); SRVR:CY1PR0701MB1980; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1980; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1980; 4:792VqJFaqNJMs4nkc6pnc+y1z+89SGpb/UsbeW2dx/PV6G/x06zq1Gaw+5JBzmGd/K9/tk5YfFL3qW7MjAzPf67ZeQpMSik7zBSPHZ+GccDlHO/qOpM4zoT0Ot4zOMWsQnHgU/4dwF2bCtEbMrOhZ9HHj70PbM/C+ux6ZfmJ44l8bfmtzUfMg/zsUdq6lbNKzZQgk7MlCQl2vm+6Q+GaH8kz7tkDW2ifdNyOBHhC9jJC18ntS9cKv2kFLlos1ac357Yt59oHoUPm/QYnt2p2aPYxCGv+WThWztF7WdBZp9isnJOuCoa3viMBJJ3YgP1wcUTGGrxIO9Z8WndB2vNi1mKv5QLkDpOkO/OEIItfqueSS9Wo0wLA21Nr8NfE2084 X-Forefront-PRVS: 0748FF9A04 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(199003)(252514010)(189002)(24454002)(93886004)(5008740100001)(47776003)(110136002)(92566002)(5001960100002)(5004730100002)(189998001)(86362001)(2950100001)(575784001)(5007970100001)(77096005)(50466002)(81156007)(83506001)(46406003)(40100003)(4001350100001)(87976001)(23726002)(106356001)(101416001)(122386002)(105586002)(33656002)(19580395003)(42186005)(15974865002)(19580405001)(97756001)(54356999)(50986999)(76176999)(61506002)(66066001)(97736004)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1980; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1980; 23:f7DgrmdDayHDVrJTfjpBuJu+AMUp6IC9/xb8qRx?= =?us-ascii?Q?EcvGLMBJYPgaoGdcLkSCO+A6cnWd+vLcAMIpeyhFN6a2S3Gt96h9ZzYDbA/+?= =?us-ascii?Q?MYZOI4Dv6B6PfVU7w5ITFp2zela8337Hvu+V+pcl15SYpXAbscjL/xYcJGSe?= =?us-ascii?Q?MCo7SvDDQKgOwGet/TRuPXRnPkXQpJoFeCmyOT5NNlf+P8h3EDUfMOIKuO5/?= =?us-ascii?Q?b5NpUATfXPg1JZEWPoOiXOV0VXWvwK69a1YJtzxN+StQbPWrSim3Z5eGO0qm?= =?us-ascii?Q?mRMSttr5muf/GYKyLJAQloPvg5LMV+XyfMrZLplwqNQn3okAF+7YigloW91o?= =?us-ascii?Q?X3ETCAaw3u9xeXpaAy2UPdONHDYu/A6xSXqs4xWcuJFaRbTQzlub/nhDr8b0?= =?us-ascii?Q?1NsQ6ZW1LOEP7RRiV4tock7tw1pa2F8NMxopO8QFPb6ihCJNDdewHS+7TJC/?= =?us-ascii?Q?e9KzKeeiATaywf3ppTWVXuh5MKGVhxBfLr/p+XYr/7lvX8F1Alhfs+gROj+Z?= =?us-ascii?Q?F1/j8T+r3n4mi/S6nsvJ+alsqof7fmxFoYeSkdZNyOysGHQnVHZ0GaytlTta?= =?us-ascii?Q?IItKFf5anK7fZi2giHqQm0e45A7ssfX8n5CQC5k1Rqt2EI/AOQwamkdY0y7G?= =?us-ascii?Q?p0CvmFV0tj3BuJQgZPBhbHDBfUHCefn5zqv5iuBnmteFdi1W/ODev42vIWDP?= =?us-ascii?Q?4pSPyg/A5HSYkjcCYSqgB9BrV8PKk165kBLda/iZVmqXT6wPHgLIHM852x10?= =?us-ascii?Q?xBBWK7fXfk8XEsTuw8gGmZyiZM5SR7t16HaQ0HoTWbCUojEFRTpyBbJf+AQg?= =?us-ascii?Q?/S7+j+HljJJwL+HngLVK25fuCNYr31erslo4qdi/HxmjZ0Nhq0XUR/kGGVOM?= =?us-ascii?Q?6/xvU2DMi+cWB66UFeTc+JxxyDk1C8Cy1xef+cAFN1qVkueWowaypp5+EviC?= =?us-ascii?Q?UUeX/iibQIc/krdL5vE/v3r/C1NscMlT3YCVgtMBQjTVt1E0cyZO9W4wdPs6?= =?us-ascii?Q?2+/Grv7OGiUiLpcSbr1bGGT9rYUcasFH6fcE/uzxGvd7GjP6mdey4O6KMU80?= =?us-ascii?Q?pLQJ8YYGHpasLXAVADR1BoxOe4jy+UV3mpxPSF657Kqx0rUDAS1V2e/wcJjG?= =?us-ascii?Q?VTGLuyMPKvSl8YJVgnbhqIFc0DD+qPSMgMPW6MqLhFVMCjnV5hlVr1VWZ1e4?= =?us-ascii?Q?nHMEVtbcsIAKc/J0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1980; 5:zsn/9sDVSD0h8m4UJ/IgUq8sLnmPe3BuHKicGC2LVpFIYtRyjxG1a0N+346EDcl0qS12s6F47S/eSI4iL9ojtA29vRz/1F4DxNRLMp1JMaZB1LIZnpB2scFMOb1aabypAy+aKisGrQYdffeMDOjvaw==; 24:HfLnqaYqfZ1sbnM7xkp/9DlJSxB8E3BQC2MbTxL1l/8FqfsJYOkOtOFcNhaYxrm6KPk09QEjjsPM/Jr522o94vkN32zC+gUwyvA5JcC4b2U=; 20:/2by+iGPM8uhbu84zJvMxGzUNjSWQprcC9FJdyd3+c766rCug44psO87z+AD8O/cFHg7PDn3pR/qZB657MFy6Q== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2015 16:20:13.0360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1980 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/3] arm64: acl: add neon based acl implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 16:20:17 -0000 On Mon, Nov 02, 2015 at 04:39:37PM +0100, Jan Viktorin wrote: > On Mon, 2 Nov 2015 19:48:40 +0530 > Jerin Jacob wrote: > > > Signed-off-by: Jerin Jacob > > --- > > app/test-acl/main.c | 4 + > > lib/librte_acl/Makefile | 5 + > > lib/librte_acl/acl.h | 4 + > > lib/librte_acl/acl_run_neon.c | 46 +++++++ > > lib/librte_acl/acl_run_neon.h | 290 ++++++++++++++++++++++++++++++++++++++++++ > > lib/librte_acl/rte_acl.c | 25 ++++ > > lib/librte_acl/rte_acl.h | 1 + > > 7 files changed, 375 insertions(+) > > create mode 100644 lib/librte_acl/acl_run_neon.c > > create mode 100644 lib/librte_acl/acl_run_neon.h > > > > diff --git a/app/test-acl/main.c b/app/test-acl/main.c > > index 72ce83c..0b0c093 100644 > > --- a/app/test-acl/main.c > > +++ b/app/test-acl/main.c > > @@ -101,6 +101,10 @@ static const struct acl_alg acl_alg[] = { > > .name = "avx2", > > .alg = RTE_ACL_CLASSIFY_AVX2, > > }, > > + { > > + .name = "neon", > > + .alg = RTE_ACL_CLASSIFY_NEON, > > + }, > > }; > > > > static struct { > > diff --git a/lib/librte_acl/Makefile b/lib/librte_acl/Makefile > > index 7a1cf8a..27f91d5 100644 > > --- a/lib/librte_acl/Makefile > > +++ b/lib/librte_acl/Makefile > > @@ -48,9 +48,14 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += rte_acl.c > > SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_bld.c > > SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_gen.c > > SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_scalar.c > > +ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > > +SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_neon.c > > Are the used NEON instrinsics for ACL ARMv8-specific? If so, the file should be named > something like acl_run_neonv8.c... > Yes, bit of armv8 specific, looks like vqtbl1q_u8 NEON instrinsics defined only in armv8. I could rename to acl_run_neonv8.c but keeping as acl_run_neon.c, may in future it can be extend to armv7 also. I am open to any decision, let me know your views. > > +else > > SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_sse.c > > +endif > > > > CFLAGS_acl_run_sse.o += -msse4.1 > > +CFLAGS_acl_run_neon.o += -flax-vector-conversions -Wno-maybe-uninitialized > > From man gcc: > > -flax-vector-conversions > Allow implicit conversions between vectors with differing numbers of elements and/or > incompatible element types. This option should not be used for new code. > > I've already pointed to this in the Dave's ARMv8 patchset. They dropped it silently. > What is the purpose? Is it necessary? Yes, the same tr hi value we can representing as unsigned and signed based on it DFA or QRANGE . > > Jan > > > > > # > > # If the compiler supports AVX2 instructions, > > diff --git a/lib/librte_acl/acl.h b/lib/librte_acl/acl.h > > index eb4930c..09d6784 100644 > > --- a/lib/librte_acl/acl.h > > +++ b/lib/librte_acl/acl.h > > @@ -230,6 +230,10 @@ int > > rte_acl_classify_avx2(const struct rte_acl_ctx *ctx, const uint8_t **data, > > uint32_t *results, uint32_t num, uint32_t categories); > > > --snip-- > > -- > Jan Viktorin E-mail: Viktorin@RehiveTech.com > System Architect Web: www.RehiveTech.com > RehiveTech > Brno, Czech Republic