From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 5AE6C5954 for ; Mon, 2 Nov 2015 19:28:00 +0100 (CET) Received: by wmeg8 with SMTP id g8so66514449wme.0 for ; Mon, 02 Nov 2015 10:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to; bh=ppeC+SCMNxcbASbHujpsSoViLHWfTqf4KF7aBekZEjA=; b=EaLVQW5YamWuvYddHcwXDhusNOD5/ELh2hckQeOfrJBMLWOGwUbyKBWLniHLDEYI+/ SRe2sxoch7YI60G0G4OxSBn03RNohjbgqs/c7XT7oHrVptc7K7gQe+chhQyIkSj4NjA5 ZxsTkB8E0NOffMOXwjnd79n0ZTof4ERW7kW3r5RRhwFwlSr2qmW+4Ej+rk9AI8UKaIf0 MfZHWLyRJpbc1oNgwT1DQF2BXCRX7pm1qHFekWqlR9jVT8ykp96cywY6tTD8iBOMaOlG dRZuneZP9pOMUrJpLgtmwMZTZ6Wf1wO47JJFXcPywlsJOZ8WxdwbauU/PXOmZIWbnpin tpfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-type :content-disposition:in-reply-to; bh=ppeC+SCMNxcbASbHujpsSoViLHWfTqf4KF7aBekZEjA=; b=C7CZDSUivBKr/gej/OcT3I0J2hYG7qVLTxY2R12N4lfZKtrm6MeX6Nw7h+b052sNaf gL2JDuBNICm458VMWd0YElMK5NZwPUEFYxLvRbvUQcDPWFoasziG7Bo7YUzqtFv+Khs8 szL0vJm/a4TfkXtRupcMcfA11ixgMm1NeyVQ7DX8NczNwq1bR5djmuFoddNvKUkgTrIA E86ChizGzxl7DR/ksKD8VG9sRZbAleDouLU1iUmvFcuMc027LNE/YWj9FXPINne0l65v /RSarQkzZZsQj4PjQWw3heYLsw2GiG28a7oatnOIrnjf2L90Dlxt07+HqhhFX+Svs6pk Pocg== X-Gm-Message-State: ALoCoQlmEDSgNJdW4vG5eR5JFnRG9Xr3wWuWeDSTNKAGgfyzrPyYG9re3CI0GsHcq1SgvqsdLVFg X-Received: by 10.28.10.132 with SMTP id 126mr14182836wmk.97.1446488880182; Mon, 02 Nov 2015 10:28:00 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c1sm23665027wjf.19.2015.11.02.10.27.59 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 02 Nov 2015 10:27:59 -0800 (PST) Date: Mon, 2 Nov 2015 19:27:40 +0100 From: Adrien Mazarguil To: Stephen Hemminger Message-ID: <20151102182740.GH3518@6wind.com> Mail-Followup-To: Stephen Hemminger , dev@dpdk.org References: <1444067589-29513-1-git-send-email-adrien.mazarguil@6wind.com> <1446231162-8075-1-git-send-email-adrien.mazarguil@6wind.com> <1446231162-8075-10-git-send-email-adrien.mazarguil@6wind.com> <20151102095217.7d40e38f@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151102095217.7d40e38f@xeon-e3> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 09/13] mlx5: add link update device operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 18:28:00 -0000 On Mon, Nov 02, 2015 at 09:52:17AM -0800, Stephen Hemminger wrote: > On Fri, 30 Oct 2015 19:52:38 +0100 > Adrien Mazarguil wrote: > > > +static int > > +mlx5_link_update_unlocked(struct rte_eth_dev *dev, int wait_to_complete) > > +{ > > + struct priv *priv = dev->data->dev_private; > > + struct ethtool_cmd edata = { > > + .cmd = ETHTOOL_GSET > > + }; > > + struct ifreq ifr; > > + struct rte_eth_link dev_link; > > + int link_speed = 0; > > + > > + (void)wait_to_complete; > > DPDK style is to use the __rte_unused attribute rather than dummy statements > to avoid unused warnings. Thanks for pointing this out, I'm used to avoiding C extensions whenever possible but will stick to DPDK style next time. Still, it would be nice if we could steer DPDK away from such extensions as much as possible. As a library, we should allow user applications to compile with flags we can't control (such as -pedantic -std=c99, and various -Wsomething). -- Adrien Mazarguil 6WIND