From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id A95608E7B for ; Tue, 3 Nov 2015 11:35:56 +0100 (CET) Received: from jvn (dynamic-109-81-211-153.ipv4.broadband.iol.cz [109.81.211.153]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3nqnZh1Mn4z39N; Tue, 3 Nov 2015 11:35:56 +0100 (CET) Date: Tue, 3 Nov 2015 11:35:48 +0100 From: Jan Viktorin To: "Ananyev, Konstantin" Message-ID: <20151103113548.3c7d4224@jvn> In-Reply-To: <2601191342CEEE43887BDE71AB97725836AB8AA2@irsmsx105.ger.corp.intel.com> References: <1446473921-12706-1-git-send-email-jerin.jacob@caviumnetworks.com> <1446473921-12706-2-git-send-email-jerin.jacob@caviumnetworks.com> <1446473921-12706-3-git-send-email-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB97725836AB86A5@irsmsx105.ger.corp.intel.com> <20151103043051.GA2228@localhost.localdomain> <2601191342CEEE43887BDE71AB97725836AB8AA2@irsmsx105.ger.corp.intel.com> Organization: RehiveTech X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/3] arm64: acl: add neon based acl implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 10:35:56 -0000 On Tue, 3 Nov 2015 10:23:55 +0000 "Ananyev, Konstantin" wrote: > > Hi Konstantin, > > > > > > On ARM, is there any specific cpu flag that you can use to determine is NEON > > > isa is supported or not? > > > > Yes, on armv7(RTE_CPUFLAG_NEON). On armv8-a NEON is mandatory. > > > > > It would be good to avoid extra conditional compilation here if possible. > > neon acl is verified/ported only on armv8. While adding the armv7 support the > > check can be extended for cpuflag based on RTE_CPUFLAG_NEON on armv7 > > Ok, and is there a flag that allows to distinguish between armv7 and arm8 then at runtime? > It is probably ok like that, but with all that conditional compilations it gets too messy. > Another thing - if you can distinguish between armv7 and armv8 at runtime, then you probably > can set alg = RTE_ACL_CLASSIFY_DEFAULT for armv7 and alg = RTE_ACL_CLASSIFY_NEON for arm8? > Konstantin The ARMv7 provides "v7l" in the AT_PLATFORM and the ARMv8 gives "aarach64". However, I am afraid, as these are two distinct platforms (with distinct cpuflags), we cannot use the cpuflags easily for this. Is there an API in DPDK which allows to ask globally: "what platform am I running on?"? Jan > > > > > > Another question - did I get it right that NEON isa is supported on all > > > possible RTE_ARCH_ARM64 cpu models you plan to support? > > > > Yes -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic