From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id CB8A5559C for ; Mon, 9 Nov 2015 16:54:44 +0100 (CET) Received: by wmec201 with SMTP id c201so87036977wme.0 for ; Mon, 09 Nov 2015 07:54:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=T2B6TBsN5KkgKs0mOgSZfO8ePfk0z5ooxhMvNi1EXRg=; b=eKeAZgjicxE66PK8AYxB9l8o03RbCcb4FVtaNlGUMsyKw8nY5PCDcG5pNMOnZm6a4w D3oPxuad8pybs9jIl//WUcoUKSojGG6E1GyTuo2NAC/+sFRK1mJe4xhqcw7SJ/FzN6jk M/WTy0BtdRQr6pt3eN36mmDvloknnt607ijBvGng4Ux8oiIgj4JbrDNo1Bx4aFmLjBy8 xRcpS4qibYuGkY3QAN4GlfkLYlpEIDP++xDGOsZPmqEl8prEL74IBRRFG6HaHn6JxmhR rKmtozl7keHaalr/v1WI3tJJb+IHbph564dgqDDe8kGibiu8OBlkC+MC1lE8LsrA7HIf 7bBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=T2B6TBsN5KkgKs0mOgSZfO8ePfk0z5ooxhMvNi1EXRg=; b=dtREw4fwZ2oFOHlPx7oH5OWzSdhUmwmFytAagtcPxH3sguUxKGrKuTcoxPbWMGhmpn aJ+2/ww7T5ic/dcpW9cTFDbJsAy47zjTSv9PHP6ekrFbTuDX0PLYcGHF2fXjsphLDqMO iypcNhP4R/i9IBv7gQiWHcecnyXCxlB8BJep6rIM6E5kDXzbps9NuE/KhFMQUF1g1wTU /NdS5YhTgETrjMDnRtf0ybpNJ4mF31nBUxQfQsXtxd0PonxteC+DcGLFBGFpcSGhFRs+ lW4sbFVSFIY3G5RZK+KMLwXHIohR3DNHpldHZj+BdYAAnWE7Ik37BiCxEIGOpzrFmzOH 1sHg== X-Gm-Message-State: ALoCoQlmvNT2CGegaSi2hUo3ulNVVTPjeGhTSEq6zC/tHT8vdqHegbuH9xs7dOd3u1rCIaaFAOXf X-Received: by 10.194.91.234 with SMTP id ch10mr658810wjb.69.1447084484544; Mon, 09 Nov 2015 07:54:44 -0800 (PST) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id l1sm17590010wmb.1.2015.11.09.07.54.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Nov 2015 07:54:44 -0800 (PST) Date: Mon, 9 Nov 2015 16:54:25 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Mcnamara, John" Message-ID: <20151109155425.GK1968@autoinstall.dev.6wind.com> References: <1446717516-17692-1-git-send-email-john.mcnamara@intel.com> <20151105165044.GA18667@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] cmdline: increase commandline buffer size to 512 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2015 15:54:44 -0000 On Mon, Nov 09, 2015 at 11:45:04AM +0000, Mcnamara, John wrote: > > > > -----Original Message----- > > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Thursday, November 5, 2015 4:51 PM > > To: Mcnamara, John; Olivier Matz; Thomas Monjalon > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] cmdline: increase commandline buffer size > > to 512 > > > > On Thu, Nov 05, 2015 at 09:58:36AM +0000, John McNamara wrote: > > > Increase commandline buffer size to 512 to allow for longer > > > commandlines required by testpmd when dealing with flow director and > > > IPv6 addresses. > > > > > > ... > > > > > > /* configuration */ > > > -#define RDLINE_BUF_SIZE 256 > > > +#define RDLINE_BUF_SIZE 512 > > > > > > > I have faced the same issue. For some commands this value is still too > > low. For example, RETA update can not be used, the command line limits > > he configuration to 34 entries. > > > > See http://dpdk.org/ml/archives/dev/2015-October/024681.html > > and particularly > > http://dpdk.org/ml/archives/dev/2015-October/024682.html > > > > It was too late to announce an ABI change so we left out the cmdline > > size update. > > > > Olivier, Thomas, what do you think about this? It seems this is really > > blocking. > > Hi, > > Since the change breaks ABI I'll self nack. > > However, this is something that should be fixed since it will affect any DPDK application with a long commandline. > > I can put a warning of future ABI breakage in the release notes but I see that there are other #defines that you need to increase in your patchset so do you want to submit the ABI deprecation notice? > > John. > -- Hi John, I will do it, I have another depreciation related to RETA. Thanks. -- Nélio Laranjeiro 6WIND