From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 792519595 for ; Fri, 13 Nov 2015 17:07:30 +0100 (CET) Received: by pasz6 with SMTP id z6so107476873pas.2 for ; Fri, 13 Nov 2015 08:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber_org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=kRYCaV3v16UMwmb/5bB3L3/6XJpcnb9uZAw+RzLHbZQ=; b=wvbuLGEiZ235632yYc+Nqr/2Pe6M6jzBf0WN0IFLL6nD8iuwQRq7t7pEWoTN+pzjmc nrUQu689ogje/u58vlb7e6pQ9GdyH0VDkLHvMl1PfEfQmjaHNieOMNLwQXthvyk6g0CI pMZFMaKnO+13HKCYgmBzAxarC+t3LUd/tl/Qrip7ywkdpbiAWLsrKRKuKqPmuwunwVp+ 8ZeLWE/ddj4Z/iKaqGOTG1XfuEQIrTOvZwajtHu1worB4EQJnA8o8v93y9wlDa7TIPmI FKUm3j4pUcGF1zUjEPSvOOesO78cEgwFCmEQye5PXFzy0LJQ405dWe2ZLOSjD52jVirF ubEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=kRYCaV3v16UMwmb/5bB3L3/6XJpcnb9uZAw+RzLHbZQ=; b=Stf3H3M2aOdG2mKyaJzL0Q+lF+W1anOQGdGbhqdE12ezsUTF3cKVepoF/UZ6BeZ1xg CBiLr4ZDLkiUkvknmBcfqyrjMEcH+983juZhz6kCnxJ0Zds8Rz9YY2RoO3j3DuxpREVj 7+UUWxaopMBZV7EGdoq9Cjf3vm400GbQRN5xR4x8n5Fxei95k2VBe+vyfNzkLXVXima8 5Vnj/yl2B8FO2lLIC2Xa3FLdnFaoAnuGejhf6LAOQdy/UgW4jQKk29gnF0pB3S7lFxAO uqLblE5iaeT620whmM5JyK2/D+vhDGlPkbtBVVqH4DFWMeRE1I1uprONEz84GKxb66BZ DWUw== X-Gm-Message-State: ALoCoQlZzUViojQwIObsXQSjO8Zne6izcshA3LjDTh5QpuY+Z5IfOm33b27onopPE/jBB7dXdWXY X-Received: by 10.66.227.231 with SMTP id sd7mr32652011pac.60.1447430849544; Fri, 13 Nov 2015 08:07:29 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id bp2sm21214778pbc.46.2015.11.13.08.07.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Nov 2015 08:07:29 -0800 (PST) Date: Fri, 13 Nov 2015 08:07:41 -0800 From: Stephen Hemminger To: Matthew Hall Message-ID: <20151113080741.1ed783d0@xeon-e3> In-Reply-To: <1447397258-27233-3-git-send-email-mhall@mhcomputing.net> References: <1447397258-27233-1-git-send-email-mhall@mhcomputing.net> <1447397258-27233-3-git-send-email-mhall@mhcomputing.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels RTE_LOG{FINE, FINER, FINEST} X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 16:07:30 -0000 On Fri, 13 Nov 2015 06:47:34 +0000 Matthew Hall wrote: > Signed-off-by: Matthew Hall > --- > lib/librte_eal/common/include/rte_log.h | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h > index 9dad24e..7dc19e1 100644 > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -90,14 +90,17 @@ extern struct rte_logs rte_logs; > #define RTE_LOGTYPE_USER8 0x80000000 /**< User-defined log type 8. */ > > /* Can't use 0, as it gives compiler warnings */ > -#define RTE_LOG_EMERG 1U /**< System is unusable. */ > -#define RTE_LOG_ALERT 2U /**< Action must be taken immediately. */ > -#define RTE_LOG_CRIT 3U /**< Critical conditions. */ > -#define RTE_LOG_ERR 4U /**< Error conditions. */ > -#define RTE_LOG_WARNING 5U /**< Warning conditions. */ > -#define RTE_LOG_NOTICE 6U /**< Normal but significant condition. */ > -#define RTE_LOG_INFO 7U /**< Informational. */ > -#define RTE_LOG_DEBUG 8U /**< Debug-level messages. */ > +#define RTE_LOG_EMERG 1U /**< System is unusable. */ > +#define RTE_LOG_ALERT 2U /**< Action must be taken immediately. */ > +#define RTE_LOG_CRIT 3U /**< Critical conditions. */ > +#define RTE_LOG_ERR 4U /**< Error conditions. */ > +#define RTE_LOG_WARNING 5U /**< Warning conditions. */ > +#define RTE_LOG_NOTICE 6U /**< Normal but significant condition. */ > +#define RTE_LOG_INFO 7U /**< Informational. */ > +#define RTE_LOG_DEBUG 8U /**< Debug-level messages. */ > +#define RTE_LOG_FINE 9U /**< Fine-level messages. */ > +#define RTE_LOG_FINER 10U /**< Finer-level messages. */ > +#define RTE_LOG_FINEST 11U /**< Finest-level messages. */ > > /** The default log stream. */ > extern FILE *eal_default_log_stream; I understand the motivation but the existing levels match syslog which are what you want for a production application. The new levels are only for developer logs. I don't think we want all the developer levels beyond debug in the upstream tree anyway.