From: Bruce Richardson <bruce.richardson@intel.com>
To: kamasamikon <kamasamikon@qq.com>
Cc: dev@dpdk.org, Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>
Subject: Re: [dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function.
Date: Fri, 13 Nov 2015 10:00:25 +0000 [thread overview]
Message-ID: <20151113100024.GA3684@bricha3-MOBL3> (raw)
In-Reply-To: <1447396093-29004-1-git-send-email-kamasamikon@qq.com>
On Fri, Nov 13, 2015 at 02:28:13PM +0800, kamasamikon wrote:
> Give user a chance to costomize the hash key compare function.
> The default rte_hash_cmp_eq function is set in the rte_hash_create
> function, but these builtin ones may not good enough, so the user
> may call this to override the default one.
>
> Signed-off-by: Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>
> ---
Hi,
Just a few small comments:
When adding a new function, you'll need to update the map file for the library
with the new API so it can be correctly versionned.
Also, using function pointers does not work with DPDK multi-process, so, at
minimum, you need to add to the doxygen documentation that your new function cannot
be used in multi-process mode.
/Bruce
next prev parent reply other threads:[~2015-11-13 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 6:28 kamasamikon
2015-11-13 10:00 ` Bruce Richardson [this message]
2015-11-19 1:15 Yu Nemo Wenbin
2015-11-24 14:06 ` De Lara Guarch, Pablo
2015-11-27 2:11 Yu Nemo Wenbin
2015-11-30 8:34 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113100024.GA3684@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kamasamikon@qq.com \
--cc=yuwb_bjy@ctbri.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).