From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6673693CA for ; Fri, 13 Nov 2015 12:44:45 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 13 Nov 2015 03:44:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,287,1444719600"; d="scan'208";a="850304044" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by fmsmga002.fm.intel.com with SMTP; 13 Nov 2015 03:44:03 -0800 Received: by (sSMTP sendmail emulation); Fri, 13 Nov 2015 11:44:03 +0025 Date: Fri, 13 Nov 2015 11:44:03 +0000 From: Bruce Richardson To: Matthew Hall Message-ID: <20151113114402.GB15612@bricha3-MOBL3> References: <1447397258-27233-1-git-send-email-mhall@mhcomputing.net> <1447397258-27233-3-git-send-email-mhall@mhcomputing.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447397258-27233-3-git-send-email-mhall@mhcomputing.net> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels RTE_LOG{FINE, FINER, FINEST} X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 11:44:46 -0000 On Fri, Nov 13, 2015 at 06:47:34AM +0000, Matthew Hall wrote: > Signed-off-by: Matthew Hall > --- > lib/librte_eal/common/include/rte_log.h | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h > index 9dad24e..7dc19e1 100644 > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -90,14 +90,17 @@ extern struct rte_logs rte_logs; > #define RTE_LOGTYPE_USER8 0x80000000 /**< User-defined log type 8. */ > > /* Can't use 0, as it gives compiler warnings */ > -#define RTE_LOG_EMERG 1U /**< System is unusable. */ > -#define RTE_LOG_ALERT 2U /**< Action must be taken immediately. */ > -#define RTE_LOG_CRIT 3U /**< Critical conditions. */ > -#define RTE_LOG_ERR 4U /**< Error conditions. */ > -#define RTE_LOG_WARNING 5U /**< Warning conditions. */ > -#define RTE_LOG_NOTICE 6U /**< Normal but significant condition. */ > -#define RTE_LOG_INFO 7U /**< Informational. */ > -#define RTE_LOG_DEBUG 8U /**< Debug-level messages. */ > +#define RTE_LOG_EMERG 1U /**< System is unusable. */ > +#define RTE_LOG_ALERT 2U /**< Action must be taken immediately. */ > +#define RTE_LOG_CRIT 3U /**< Critical conditions. */ > +#define RTE_LOG_ERR 4U /**< Error conditions. */ > +#define RTE_LOG_WARNING 5U /**< Warning conditions. */ > +#define RTE_LOG_NOTICE 6U /**< Normal but significant condition. */ > +#define RTE_LOG_INFO 7U /**< Informational. */ > +#define RTE_LOG_DEBUG 8U /**< Debug-level messages. */ > +#define RTE_LOG_FINE 9U /**< Fine-level messages. */ > +#define RTE_LOG_FINER 10U /**< Finer-level messages. */ > +#define RTE_LOG_FINEST 11U /**< Finest-level messages. */ > > /** The default log stream. */ > extern FILE *eal_default_log_stream; > -- > 1.9.1 > Why 11 log levels - it seems an odd number? Also, not sure about the {fine, finer, finest} names. My thinking would be to just start numbering them after DEBUG, so RTE_LOG_L9, RTE_LOG_L10 etc., which would allow us to add on an arbitrary number of extra log levels as needed. /Bruce