From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Cc: Felix Marti <felix@chelsio.com>,
Kumar Sanghvi <kumaras@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: [dpdk-dev] Recent changes related to interrupt thread
Date: Mon, 16 Nov 2015 18:02:02 +0530 [thread overview]
Message-ID: <20151116123200.GA2667@scalar.blr.asicdesigners.com> (raw)
Hi,
I notice that the following changeset:
Fixes: fd6949c55c9a ("eal: fix io permission for virtio interrupt
handler")
has moved the initialization of the interrupt thread to after the master
lcore has been initialized. However, this causes the interrupt thread
to _inherit_ the affinity of the master lcore. Hence, this seems to
make all interrupts to be handled by _only_ the master lcore. Because
of this change, it seems that now alarm interrupts would also be handled
by master lcore only, IIUC.
We are seeing a performance regression for cxgbe PMD after this commit
since, cxgbe PMD relies on alarm to periodically transmit pending
coalesced packets.
Also, this perf degradation is only seen if there's a queue allocated
on the master lcore, such as in l3fwd app. If the master lcore has
been skipped, then no degradation in perf is seen since only the alarm
will run on the master lcore.
So, is the change done to make all interrupts, including alarm
interrupts, be handled by _only_ the master lcore intended?
BTW, I have tried setting the affinity to all cpus instead in
eal_intr_init() and this seems to restore the perf back. Perhaps it's
better to move the master lcore initialization to after the interrupt
thread has been initialized as well? Thoughts?
Thanks,
Rahul
next reply other threads:[~2015-11-16 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 12:32 Rahul Lakkireddy [this message]
2015-11-16 13:48 ` Thomas Monjalon
2015-11-16 17:06 ` Stephen Hemminger
2015-11-16 17:19 ` Ananyev, Konstantin
2015-11-16 17:40 ` Stephen Hemminger
[not found] ` <2601191342CEEE43887BDE71AB97725836AC98E9@irsmsx105.ger.corp.intel.com>
2015-11-17 11:48 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116123200.GA2667@scalar.blr.asicdesigners.com \
--to=rahul.lakkireddy@chelsio.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=felix@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).