From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id B11B48DA5
 for <dev@dpdk.org>; Thu, 19 Nov 2015 14:39:27 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 19 Nov 2015 05:39:26 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,318,1444719600"; d="scan'208";a="854822734"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by fmsmga002.fm.intel.com with ESMTP; 19 Nov 2015 05:39:26 -0800
Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com
 [10.237.217.37])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 tAJDdPBS019622; Thu, 19 Nov 2015 13:39:25 GMT
Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1])
 by sivlogin002.ir.intel.com with ESMTP id tAJDdOox028683;
 Thu, 19 Nov 2015 13:39:24 GMT
Received: (from fyigit@localhost)
	by sivlogin002.ir.intel.com with œ id tAJDdOHb028679;
	Thu, 19 Nov 2015 13:39:24 GMT
X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to
 ferruh.yigit@intel.com using -f
Date: Thu, 19 Nov 2015 13:39:24 +0000
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20151119133924.GA28008@sivlogin002.ir.intel.com>
Mail-Followup-To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org,
 Panu Matilainen <pmatilai@redhat.com>
References: <103431910.iACTIb73WP@xps13>
 <1447932137-16886-1-git-send-email-ferruh.yigit@intel.com>
 <564DB761.5090203@redhat.com> <8530847.T7t25DiR7m@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8530847.T7t25DiR7m@xps13>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Revert "eal: set name to threads"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2015 13:39:28 -0000

On Thu, Nov 19, 2015 at 01:32:44PM +0100, Thomas Monjalon wrote:
> 2015-11-19 13:49, Panu Matilainen:
> > On 11/19/2015 01:22 PM, Ferruh Yigit wrote:
> > > This reverts commit 67b6d3039e9edbc4624c878c6930be5e126e8b58.
> > >
> > > Reverted patch uses pthread_setname_np() function, this function added
> > > into glibc in version 2.12 and cause a compile error in older glibc
> > > versions:
> > > error: implicit declaration of function "pthread_setname_np"
> > >
> > > Main purpose of reverted patch is to name threads, without
> > > pthread_setname_np() function, patch does not mean much, so reverting
> > > patch for sake of compatibility with older glibc versions.
> > 
> > Debuggability is important too. Rather than revert, why not wrap it in 
> > rte_thread_setname() or such and just make it a no-op with glibc 
> > versions where pthread_setname_np() is not available?
> 
> +1

Which means adding compile time glibc version check which I was trying to avoid,
I believe we should not add glibc version dependencies unless feature is really required,
but sure I can implement that way, will send v2.

Thanks,
ferruh