From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DBBC08D91 for ; Thu, 19 Nov 2015 17:59:39 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 19 Nov 2015 08:59:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,318,1444719600"; d="scan'208";a="842552032" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 19 Nov 2015 08:59:39 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id tAJGxb5m022129; Thu, 19 Nov 2015 16:59:37 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id tAJGxaAL005578; Thu, 19 Nov 2015 16:59:36 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id tAJGxZRg005574; Thu, 19 Nov 2015 16:59:36 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Thu, 19 Nov 2015 16:59:35 +0000 From: Ferruh Yigit To: Thomas Monjalon , dev@dpdk.org, Panu Matilainen Message-ID: <20151119165935.GA4888@sivlogin002.ir.intel.com> Mail-Followup-To: Thomas Monjalon , dev@dpdk.org, Panu Matilainen References: <103431910.iACTIb73WP@xps13> <1447932137-16886-1-git-send-email-ferruh.yigit@intel.com> <564DB761.5090203@redhat.com> <8530847.T7t25DiR7m@xps13> <20151119133924.GA28008@sivlogin002.ir.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151119133924.GA28008@sivlogin002.ir.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [dpdk-dev] [PATCH] Revert "eal: set name to threads" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 16:59:40 -0000 On Thu, Nov 19, 2015 at 01:39:24PM +0000, Ferruh Yigit wrote: > On Thu, Nov 19, 2015 at 01:32:44PM +0100, Thomas Monjalon wrote: > > 2015-11-19 13:49, Panu Matilainen: > > > On 11/19/2015 01:22 PM, Ferruh Yigit wrote: > > > > This reverts commit 67b6d3039e9edbc4624c878c6930be5e126e8b58. > > > > > > > > Reverted patch uses pthread_setname_np() function, this function added > > > > into glibc in version 2.12 and cause a compile error in older glibc > > > > versions: > > > > error: implicit declaration of function "pthread_setname_np" > > > > > > > > Main purpose of reverted patch is to name threads, without > > > > pthread_setname_np() function, patch does not mean much, so reverting > > > > patch for sake of compatibility with older glibc versions. > > > > > > Debuggability is important too. Rather than revert, why not wrap it in > > > rte_thread_setname() or such and just make it a no-op with glibc > > > versions where pthread_setname_np() is not available? > > > > +1 > > Which means adding compile time glibc version check which I was trying to avoid, > I believe we should not add glibc version dependencies unless feature is really required, > but sure I can implement that way, will send v2. > I tried defining weak symbol within DPDK, and library already has strong version, this was nice try, thanks to Sergio, but this also does not work because how linker works, weak symbol in binary overrides the strong in shared library..