From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 1D22A5A6C
for <dev@dpdk.org>; Fri, 20 Nov 2015 13:21:08 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by orsmga101.jf.intel.com with ESMTP; 20 Nov 2015 04:21:10 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,322,1444719600"; d="scan'208";a="825077830"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.60])
by orsmga001.jf.intel.com with SMTP; 20 Nov 2015 04:21:06 -0800
Received: by (sSMTP sendmail emulation); Fri, 20 Nov 2015 12:21:05 +0025
Date: Fri, 20 Nov 2015 12:21:05 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <20151120122105.GB2528@bricha3-MOBL3>
References: <20151119165935.GA4888@sivlogin002.ir.intel.com>
<1447955066-17131-1-git-send-email-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447955066-17131-1-git-send-email-ferruh.yigit@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix compile error for old glibc caused
by pthread_setname_np()#
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2015 12:21:09 -0000
On Thu, Nov 19, 2015 at 05:44:26PM +0000, Ferruh Yigit wrote:
> Fixes: 67b6d3039e9e ("eal: set name to threads")
>
> pthread_setname_np() function added in glibc 2.12, using this function
> in older glibc versions cause compile error:
> error: implicit declaration of function "pthread_setname_np"
>
> This patch adds "rte_thread_setname" macro and set it according
> glibc >= 2.12 check, thread naming disabled for older glibc versions,
> glibc versions that support "pthread_setname_np" will keep using this
> function.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> examples/tep_termination/main.c | 2 +-
> examples/vhost/main.c | 2 +-
> examples/vhost_xen/main.c | 2 +-
> lib/librte_eal/common/eal_thread.h | 6 ++++++
> lib/librte_eal/linuxapp/eal/eal.c | 2 +-
> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 +-
> lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 2 +-
> lib/librte_eal/linuxapp/eal/eal_timer.c | 2 +-
> 8 files changed, 13 insertions(+), 7 deletions(-)
>
I only see changes to linux files above. Does this not also have an implication
for bsd too?
/Bruce