DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matthew Hall <mhall@mhcomputing.net>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] difficulty w/ RTE_NEXT_ABI
Date: Sun, 22 Nov 2015 18:25:09 -0500	[thread overview]
Message-ID: <20151122232509.GA27730@mhcomputing.net> (raw)
In-Reply-To: <2764108.ZoWOrsZgTX@xps13>

On Sun, Nov 22, 2015 at 09:59:30PM +0100, Thomas Monjalon wrote:
> > So again I am confused what advantage we got from RTE_NEXT_ABI here, and how 
> > you have multiple copies of RTE_NEXT_ABI on a single symbol when it is a 
> > binary variable.
> 
> I don't understand what is not clear here.

OK. Let me restate it.

I was starting from an assumption that the purpose of RTE_NEXT_ABI was to 
allow ABI changes.

In most projects I worked on, a renaming of a variable when the data type is 
unchanged does not count as an ABI change. So it seems like this is different 
from the usual definition.

Secondly, if one is making an ABI change, like I was, to some code which was 
already changed once using RTE_NEXT_ABI, which part of the code do you change?

Do you make a third copy different from the first two copies? If you make a 
third copy, but RTE_NEXT_ABI is binary (i.e. it has two values, on and off) 
then what labeling do you apply to the third copy?

If you don't make a third copy, I am assuming you edit the copy marked with 
RTE_NEXT_ABI. But then what happens to a downstream user who wants to have 
RTE_NEXT_ABI with the first ABI change, and not your second ABI change?

Can you see what I am trying to ask now?

Matthew.

  reply	other threads:[~2015-11-22 23:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21  8:49 Matthew Hall
2015-11-21 10:44 ` Thomas Monjalon
2015-11-22  0:25   ` Matthew Hall
2015-11-22 20:59     ` Thomas Monjalon
2015-11-22 23:25       ` Matthew Hall [this message]
2015-11-23  0:13         ` Thomas Monjalon
2015-11-23  3:53           ` Matthew Hall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151122232509.GA27730@mhcomputing.net \
    --to=mhall@mhcomputing.net \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).