DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matthew Hall <mhall@mhcomputing.net>
To: dev@dpdk.org
Subject: [dpdk-dev] OK to reindent the pktgen (mix of tabs and spaces, etc.)?
Date: Mon, 23 Nov 2015 02:10:37 -0500	[thread overview]
Message-ID: <20151123071037.GA1771@mhcomputing.net> (raw)

I would like to reindent it using the following astyle command, with a few 
small hand edits past that level, to get it closer to most other DPDK code as 
the inconsistent mix of tabs, spaces, etc. makes it difficult to read and 
debug when it has issues.

Obviously the upstream Lua and common/wr_* code would not be included as they 
seem to be copied from elsewhere w/ different upstream standards.

If I were to make the big diff needed for this, would this item be acceptable 
upstream?

Otherwise it is going to be hard to get more people working on the code 
reliably as it will be hard for others to follow besides the original authors.

astyle \
--max-code-length=132 \
--style=attach \
--break-closing-brackets \
--add-brackets \
--indent=force-tab=8 \
--indent-switches \
--indent-labels \
--indent-col1-comments \
--pad-oper \
--pad-header \
--unpad-paren \
--align-pointer=type \
--align-reference=type \
--suffix=none \
--lineend=linux \
./app/**/*.{c,h}

Sincerely,
Matthew.

             reply	other threads:[~2015-11-23  7:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23  7:10 Matthew Hall [this message]
2016-01-03  8:06 ` Matthew Hall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151123071037.GA1771@mhcomputing.net \
    --to=mhall@mhcomputing.net \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).