From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mhall@mhcomputing.net>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.228.170])
 by dpdk.org (Postfix) with ESMTP id 229A08E7E
 for <dev@dpdk.org>; Mon, 23 Nov 2015 08:10:40 +0100 (CET)
Received: by mail.mhcomputing.net (Postfix, from userid 1000)
 id EB56C17A; Mon, 23 Nov 2015 02:10:37 -0500 (EST)
Date: Mon, 23 Nov 2015 02:10:37 -0500
From: Matthew Hall <mhall@mhcomputing.net>
To: dev@dpdk.org
Message-ID: <20151123071037.GA1771@mhcomputing.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: [dpdk-dev] OK to reindent the pktgen (mix of tabs and spaces, etc.)?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2015 07:10:40 -0000

I would like to reindent it using the following astyle command, with a few 
small hand edits past that level, to get it closer to most other DPDK code as 
the inconsistent mix of tabs, spaces, etc. makes it difficult to read and 
debug when it has issues.

Obviously the upstream Lua and common/wr_* code would not be included as they 
seem to be copied from elsewhere w/ different upstream standards.

If I were to make the big diff needed for this, would this item be acceptable 
upstream?

Otherwise it is going to be hard to get more people working on the code 
reliably as it will be hard for others to follow besides the original authors.

astyle \
--max-code-length=132 \
--style=attach \
--break-closing-brackets \
--add-brackets \
--indent=force-tab=8 \
--indent-switches \
--indent-labels \
--indent-col1-comments \
--pad-oper \
--pad-header \
--unpad-paren \
--align-pointer=type \
--align-reference=type \
--suffix=none \
--lineend=linux \
./app/**/*.{c,h}

Sincerely,
Matthew.