DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net: fix build with gcc 4.4.7 and strict aliasing
Date: Tue, 24 Nov 2015 14:42:44 -0800	[thread overview]
Message-ID: <20151124144244.0ecf7627@xeon-e3> (raw)
In-Reply-To: <1448382678-6060-1-git-send-email-danielx.t.mrzyglod@intel.com>

On Tue, 24 Nov 2015 17:31:17 +0100
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> wrote:

> This fix is for IPv6 checksum offload error on RHEL65.
> Any optimalisation above -O0 provide error in IPv6 checksum
> flag "-fstrict-aliasing" is default for optimalisation above -O0.
> The solution is to add typedef with __attribute__((__may_alias__) for uint16_t.
> 
> Step 1 : start testpmd
> ./testpmd -c 0x6 -n 4  -- -i --portmask=0x3 --disable-hw-vlan --enable-rx-cksum --crc-strip --txqflags=0
> 
> Step 2 : settings and start
>            set verbose 1
>            set fwd csum
>            start
> 
> Step 3 : send scapy with bad checksum IPv6/TCP packet
>         Ether(src="52:00:00:00:00:00", dst="90:e2:ba:4a:33:5d")/IPv6(src="::1")/TCP(chksum=0xf)/("X"*46)
> 
> Step 4 : Recieved packets:
> RESULTS:
> IPv6/TCP': ['0xd41'] or other unexpected.
> 
> EXPECTED RESULTS:
> IPv6/TCP': ['0x9f5e']
> 
> Daniel Mrzyglod (1):
>   net: fix build with gcc 4.4.7 and strict aliasing
> 
>  lib/librte_net/rte_ip.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

An alternative way of fixing it (without resorting to attributes) would
be to use a union.

  parent reply	other threads:[~2015-11-24 22:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 15:12 [dpdk-dev] [PATCH] " Daniel Mrzyglod
2015-11-24 15:47 ` Mrzyglod, DanielX T
2015-11-24 15:49   ` Bruce Richardson
2015-11-24 16:31 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2015-11-24 16:31   ` Daniel Mrzyglod
2015-11-24 17:58     ` Ananyev, Konstantin
2015-11-25 17:06       ` Mrzyglod, DanielX T
2015-11-25 17:13         ` Ananyev, Konstantin
2015-11-24 22:42   ` Stephen Hemminger [this message]
2015-11-25 18:00 ` [dpdk-dev] [PATCH] " Ananyev, Konstantin
2015-11-25 20:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124144244.0ecf7627@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=danielx.t.mrzyglod@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).