From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 3BB038E87
 for <dev@dpdk.org>; Tue, 24 Nov 2015 19:05:23 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 24 Nov 2015 10:04:04 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,339,1444719600"; d="scan'208";a="693553694"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by orsmga003.jf.intel.com with ESMTP; 24 Nov 2015 10:04:01 -0800
Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com
 [10.237.217.37])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 tAOI41WB022958; Tue, 24 Nov 2015 18:04:01 GMT
Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1])
 by sivlogin002.ir.intel.com with ESMTP id tAOI400R016574;
 Tue, 24 Nov 2015 18:04:00 GMT
Received: (from fyigit@localhost)
	by sivlogin002.ir.intel.com with œ id tAOI40Ap016570;
	Tue, 24 Nov 2015 18:04:00 GMT
X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to
 ferruh.yigit@intel.com using -f
Date: Tue, 24 Nov 2015 18:04:00 +0000
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20151124180400.GA15834@sivlogin002.ir.intel.com>
Mail-Followup-To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
References: <1446160974-31675-1-git-send-email-ferruh.yigit@intel.com>
 <1446817732-17873-1-git-send-email-ferruh.yigit@intel.com>
 <1446817732-17873-2-git-send-email-ferruh.yigit@intel.com>
 <2076055.LzC464LxxN@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2076055.LzC464LxxN@xps13>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: add git hook scripts for	checkpatch
	and auto doc generation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2015 18:05:23 -0000

On Tue, Nov 24, 2015 at 06:44:36PM +0100, Thomas Monjalon wrote:
> Thanks for the idea
> 
> 2015-11-06 13:48, Ferruh Yigit:
> > post-merge: Same script as "post-commit", but triggered after git pull
> 
> A symbolic link would be sufficient.
> As it must be installed in the git hooks (probably making a symbolic link),
> duplicating the file is not needed at all.
> 
OK

> > pre-commit: Does a checkpatch check before commit started. If script
> > finds any error it will print warnings and fails. If  checkpatch
> > fails commit also fails. This guaranties every commit pass checkpatch.
> > Default script is <dpdk>/scripts/checkpatch.pl but this can be
> > changed by RTE_CHECKPATCH environment variable. Also a default list
> > of checkpatch ignore items defined, new ones can be added by IGNORE
> > environment variable.
> 
> Please use the new scripts/checkpatches.sh:
> http://dpdk.org/dev/patchwork/patch/9036/
> 
OK, better to use that script, to prevent duplicated IGNORE flag and checkpatch.pl location maintenance.

> > This script can bypassed by commit "--no-verify" argument.
> 
> Could you document the --no-verify option in the script?
> 
This is git feature, with that flag script not called at all, I will add this comment into script.

> > Deployment:
> > To make scripts active they need to be in <dpdk>/.git/hooks folder.
> > Alternatively "deploy.sh" script can be used, it simply copies all
> > scripts into proper folder. Script names are significant and
> > shouldn't changed.
> 
> Why not using symbolic links?
> 
Yes we can use symbolic links.

I will send updated patch.

Thanks for the review,
ferruh