From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id B0680923A for ; Wed, 25 Nov 2015 17:08:28 +0100 (CET) Received: by pacdm15 with SMTP id dm15so61378585pac.3 for ; Wed, 25 Nov 2015 08:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=OgBHe2GP8LeJ7IBbCyHmkYFmHbPUIIEsCtuObeVsiQA=; b=bPK1YuvIcD7SY2cssXLU/O4RVOj6ntkBIYb3uSOeKvm+qlAqzdFSJXO66RLO2vfCRo AMFN5Ag7RGxReVhJuOhJ3v4M/8XnxUuAxzCcYbz+qYR+Q0gZeZCiqhtCiRQ4c29y6O0g qMYs8yC1yJr+npFPisiY4VeagcmnGi9VDLfAHvt23AQQmoF8hHMkfoNG8C0m4060iqnZ tEd1qdsgXCxLWH2FbYZlZ1+l3QY762HNGXGfnwJMHbfwqxr2Au2KpTXKpcK1Yt8MpGqF rp9Z6oUyqYhp+bTvjDR5FQnKuc46cGGjG2cVOYGhnOH0mxGp0v61imB2mKb1tt7ClHJk Ne5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=OgBHe2GP8LeJ7IBbCyHmkYFmHbPUIIEsCtuObeVsiQA=; b=hSLvBqDdekcfWB+BuDIAOkyH/Lf4q1QiktXcVTqpe3BeiBqeUoxf2zyV3O+2BlQEa9 Hcgg7G1j5Uq0lTV0M6INWrJ9Kc47hX3BaRUz7W2Wj7gnPFAS4sNJbH4ZMorNuPsamuiL RQBzNTeYMgU1HsG80tf8SloUNSgH6AcLFJocPjtf7MGyZooqJv/GGZ0rfUTYdysx9glE UxY51jT0wiMOCGGH7cDSvQgrWHCLhgxiTp5le+snluxrWWrTFliBXBJ983V1BZWVmMWz 0bjht4RlwpSocgjznCSkYiEgGa0EEqgyXVcypSL0j4hnn2cckhJGbUF92W22a8Ygog7V pBZQ== X-Gm-Message-State: ALoCoQkmswRkVAJTyNsI/iW0pK7SyFx2S9xrxuxUEac3m1WYhJwpa7mFfZXEI9GW5WO9ilfWSSAL X-Received: by 10.66.219.228 with SMTP id pr4mr50426414pac.99.1448467708115; Wed, 25 Nov 2015 08:08:28 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id rn7sm22316867pab.23.2015.11.25.08.08.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Nov 2015 08:08:27 -0800 (PST) Date: Wed, 25 Nov 2015 08:08:37 -0800 From: Stephen Hemminger To: Panu Matilainen Message-ID: <20151125080837.68e24a2d@xeon-e3> In-Reply-To: <56557398.3020600@redhat.com> References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <20151124144638.0b659e7d@xeon-e3> <56557398.3020600@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2015 16:08:29 -0000 On Wed, 25 Nov 2015 10:38:48 +0200 Panu Matilainen wrote: > On 11/25/2015 12:46 AM, Stephen Hemminger wrote: > > On Tue, 24 Nov 2015 16:31:17 +0200 > > Panu Matilainen wrote: > > > >> The physically linked-together combined library has been an increasing > >> source of problems, as was predicted when library and symbol versioning > >> was introduced. Replace the complex and fragile construction with a > >> simple linker script which achieves the same without all the problems, > >> remove the related kludges from eg mlx drivers. > >> > >> Since creating the linker script is practically zero cost, remove the > >> config option and just create it always. > >> > >> Based on a patch by Sergio Gonzales Monroy, linker script approach > >> initially suggested by Neil Horman. > >> > >> Suggested-by: Sergio Gonzalez Monroy > >> Suggested-by: Neil Horman > >> Signed-off-by: Panu Matilainen > > > > But it now means distros have to ship 20 libraries which seems like > > a step back. > > That's how Fedora and RHEL are shipping it already and nobody has so > much as noticed anything strange, much less complained about it. 20 > libraries is but a drop in the ocean on a average distro. But more to > the point, distros will prefer 50 working libraries over one that doesn't. > > The combined library as it is simply is no longer a viable option. > Besides just being broken (witness the strange hacks people are coming > up with to work around issues in it) its ugly because it basically gives > the middle finger to all the effort going into version compatibility, > and its also big. Few projects will use every library in DPDK, but with > the combined library they're forced to lug the 800 pound gorilla along > needlessly. > > - Panu - > Fixing the combined library took less than an hour for us.