From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 79F319238 for ; Thu, 26 Nov 2015 19:14:49 +0100 (CET) Received: by padhx2 with SMTP id hx2so92000734pad.1 for ; Thu, 26 Nov 2015 10:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Ce1dtQzXPPOAHXgtLsbde7Tg+U1Z+Rgysaccgbu1aC0=; b=q48/ewUQL8LuZyKDv2me2uey71NgRyq2ccABBgx6Q9Jc9WSwpRCdIrvpsFaObwKMvG 7BtucpSsOpLXnI23Rw1Dy6GLneOd7aYrCQTdMs7ZzAcbHgC0vO5bNK0802CSrBLEWutt V9slM6LhhFccjoA46tiHV28HWpM8YpObwGwT3tX6GPZcdjFkBATwVJ32RNcCuj89ke+V BCvJzyx/9ukVdhL3coivLhVx6PY1xJhXMfv89hNeWpSnFjdEfV+dXDoUIuTmVAF3ToDd NkSD17rhLUOWSBz1DKogAzzELYI2XC2QF8IHXkvh7JbvOfYx1XpqP59zFtQoGeaFsG7t FJ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Ce1dtQzXPPOAHXgtLsbde7Tg+U1Z+Rgysaccgbu1aC0=; b=PXtBqM+oiWZQQa7yk39wJJ8Y4L8eLqFL7XzBo6ZmTNX4n7ZYLFRfDZ+PC8d0JQTXsh 9oBrwhv+wat+vJzifCEHEQQPc77FIr1Zhrlspc9mcqQ1Pc7kd+w1fcTfXJ03hD0/+qMN 3QjqJi10k5DgIua0bsDSNO1hmN836VLTlrlDIDFf8s2jW0YGAn3EszJqb+ddrSA1hilZ IXHL6xvGjv8KBCvaO4Ti6rskkdTl6DFSwPQFhG7cS7pJpyX88bG4L/pCFMMVxTyH9zBN I3hRn1LJRCcSxFUPDxs9YrKTk5+rOP9IspV99hxgyoX1P6rATaKDAHrK7x4WTTtkiPcX xlTA== X-Gm-Message-State: ALoCoQnrrmKqvQDtfkoKWrlY7r5nqoiuX6ZC95Na40x3T+/MTajJtdUc0xL8ClAzirGz49Yu75Zr X-Received: by 10.98.19.130 with SMTP id 2mr41848436pft.93.1448561688775; Thu, 26 Nov 2015 10:14:48 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id uy1sm29457792pac.39.2015.11.26.10.14.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Nov 2015 10:14:48 -0800 (PST) Date: Thu, 26 Nov 2015 10:14:49 -0800 From: Stephen Hemminger To: Alejandro Lucero Message-ID: <20151126101449.3f450a14@xeon-e3> In-Reply-To: <1448531369-8808-2-git-send-email-alejandro.lucero@netronome.com> References: <1448531369-8808-1-git-send-email-alejandro.lucero@netronome.com> <1448531369-8808-2-git-send-email-alejandro.lucero@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v9 1/9] nfp: basic initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2015 18:14:49 -0000 On Thu, 26 Nov 2015 09:49:21 +0000 Alejandro Lucero wrote: > +static inline void > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val) > +{ > + uint32_t off; Minor nit. why mix use of Linux specific basic size typedefs (__u8) with Posix standard values (uint32_t). The DPDK style is to use the Posix types except in kernel drivers or code that is coming from unified drivers (ie ixgbe/base)