From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C18515683 for ; Fri, 27 Nov 2015 17:18:28 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 27 Nov 2015 08:17:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,352,1444719600"; d="scan'208";a="608163594" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.61]) by FMSMGA003.fm.intel.com with SMTP; 27 Nov 2015 08:17:22 -0800 Received: by (sSMTP sendmail emulation); Fri, 27 Nov 2015 16:17:22 +0025 Date: Fri, 27 Nov 2015 16:17:22 +0000 From: Bruce Richardson To: Bernard Iremonger Message-ID: <20151127161721.GC27472@bricha3-MOBL3> References: <1448640460-25249-1-git-send-email-bernard.iremonger@intel.com> <1448640460-25249-3-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448640460-25249-3-git-send-email-bernard.iremonger@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/2] doc: correct Rings-based PMD section in the NIC Drivers guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 16:18:29 -0000 On Fri, Nov 27, 2015 at 04:07:40PM +0000, Bernard Iremonger wrote: > Correct the sample code in the pcap_ring.rst file to match the latest > rte_eth_ring.c code. > > The parameters to the rte_eth_from_rings() function have changed since > the documentation was written. > The API change occurred before DPDK 1.8 when the rst files were added. > The original documentation on which the pcap_ring.rst file was based was > not correct. > > Fixes: correct the sample code in the pcap_ring.rst file. This is not a standard fixes line. Please add the following alias to your .gitconfig and then use "git fixline " to produce a correct fixes line identifying the commit being fixed. [alias] fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' /Bruce