From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 675DE7E93 for ; Sun, 29 Nov 2015 10:10:13 +0100 (CET) Received: by wmuu63 with SMTP id u63so95806974wmu.0 for ; Sun, 29 Nov 2015 01:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to; bh=T28Mj4/9FiIyHAK1BvPUWDplX1zj3o3QDS1u6pZ73cc=; b=ZOGcapEw9OwcwygcXFdwhtg4ArC1+2UjC0Ms9FLyXAXf4pV2DZmkgaDlnlP6h9Hv5I wsrAqG6r5F3lcKMwPvDK+LMZDMg77rUpKnebm6DMy8Jo25cHiSYvX1GNHQPxb7O0l/bQ oJzd99KzLfKDjlRYYfzQhEdVNN0ORJYCw6VqMSKWobOj18i9uV3ij2+4Ih8IRBK7WUrK T5wrm554CmEjcH/aCQsFTS/4lc/1GY4dtU+O/TkXhychT7UDMm/8c8yiHY5qw0Yclyil IrOhZGgdLdXmkgqQleeCX8bfVgscMfo6S/847dJz2buKGEZMyQmCHUuYX/bfYILmkxTq x1fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to; bh=T28Mj4/9FiIyHAK1BvPUWDplX1zj3o3QDS1u6pZ73cc=; b=jOmEPkAokviQP31zxpUquiGp5cLCz1QAFOKVTZvAfm/C8sj+/9a5LxLp6TluxjRkG2 p2yCsmQGoFgLzEJFwrOD0t5ds41SEPAa/3yyT3PuqD1zo2NdR7xwW7KbFKfRigUQQJUg cTdDdoaRWdnKceilsYSjfkDui/MC6eCdHHpXF+QZC/KsMQ2jSHR6DpbXss6X6bpp6xcD rvxyAMtNLoWx+B1z4DW2/LpfXp8IhHb6mqsBLIVfsHZyxcNYCSRy5PDLxFxVftDLZr6I VRw76EBE/vRTePGpuE13ZS3z4zsh7gy7hUPZwnJhqLgGlXh2CCpLMZ+ovTuVWl54akJZ gf9Q== X-Gm-Message-State: ALoCoQnyUnzJ3EdBOnSvGhkjVkMNQ1D6Zu6Tochktp5JhuZN+OmLrZqfCO0HKQ2GMP95qMHfhbda X-Received: by 10.194.110.35 with SMTP id hx3mr77060583wjb.0.1448788213226; Sun, 29 Nov 2015 01:10:13 -0800 (PST) Received: from trex.cloudius-systems.com ([37.142.229.250]) by smtp.gmail.com with ESMTPSA id f11sm15925712wmd.7.2015.11.29.01.10.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Nov 2015 01:10:12 -0800 (PST) Received: by trex.cloudius-systems.com (Postfix, from userid 1042) id 357248342E; Sun, 29 Nov 2015 11:10:11 +0200 (IST) Date: Sun, 29 Nov 2015 11:10:11 +0200 From: Gleb Natapov To: Vlad Zolotarov Message-ID: <20151129091011.GG19023@scylladb.com> References: <13076727.eWbPQotoSK@xps13> <565AC060.1060903@cloudius-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565AC060.1060903@cloudius-systems.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] API feature check _HAS_ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2015 09:10:13 -0000 On Sun, Nov 29, 2015 at 11:07:44AM +0200, Vlad Zolotarov wrote: > > > On 11/26/15 22:35, Thomas Monjalon wrote: > >When introducing LRO, Vlad has defined the macro RTE_ETHDEV_HAS_LRO_SUPPORT: > >http://dpdk.org/browse/dpdk/commit/lib/librte_ether/rte_ethdev.h?id=8eecb329 > > > >It allows to use the feature without version check (before the release or > >after a backport). > >Do you think it is useful? > >Should we define other macros RTE_[API]_HAS_[FEATURE] for each new feature > >or API change? > > The main purpose of the above macro was to identify the presence of the new > field in the rte_eth_rxmode during the > period of time when there was no other way to know it. Once this may be > concluded based on the release version I see no > reason to keep it. > Concluding things based on release version does not work so well for back ports. > >It's time to fix it before releasing the 2.2 version. > -- Gleb.