From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 85DB45A9D for ; Sun, 29 Nov 2015 16:48:27 +0100 (CET) Received: by wmuu63 with SMTP id u63so101804683wmu.0 for ; Sun, 29 Nov 2015 07:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=UQppZGHI7lM/fTRqCg2q+Qr55cdq/TrpBsSQPf8Xg4k=; b=QKYOEjYQk2zDMOmI/D6sNLcr5wKaB5qIDvUwfVw+1M2gaI90UnFIHyeBWQRWHP+cYT AlP+0gJ0/GhDsmuWTVRjTGB4wECzdKKr2hijSCH2pf+cADTXDZhS1xtwFHI381tboIj1 HVYk2GVBR0CITvYGwlr7gaiXw2Cner5ILaePE+An5CUiKLLLbzAsdlGDFp2zxVh1mTLr 8D0FX4Qujwo6+XXD0cB/etO82rymLDFyeEo9PG4HpvJ7/9BKaIGxdaNQPl5d2sp8LpmF CaoS4KMwG4yzxhxmmSKorS3qJs4es1Fzdy0XDso/9F1luzLPkbqUkIpxIHG9+d8Qovqb 8WPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=UQppZGHI7lM/fTRqCg2q+Qr55cdq/TrpBsSQPf8Xg4k=; b=IlKf44/3cHzUDqA9pSvswArZI4TF7JMiXiCegt7+PkPA/V41r+NrBSK8yxLukA7mFK jCWQSIC5tndVuqYSKGpTdX1tcxAYB//Gk9C4EjVbt2a33z9DCb31YZBqUa5uizoWhK24 dXiIDOxF22IhNv6Y+8/67BigvX4OoisvJHShgqTQQL52vjOtlaT5s6DovRTWk7xGrOeW xfteEGCn5EyULgtz7VrK40Dourf3emgyISyh+eO/YFUhWmKG34v6lCnUNHmOe0GPnbei Rj2bWYukeK4aO9QhSCumop57UDbgIHJP80Yp1Y7624yEshrkCZ+k86oLUugUMclViOMl +y6Q== X-Gm-Message-State: ALoCoQmvIN7jpM149BfFZPgTqMo5YRbJXHoZXUgzQ81rJ+apccTeZqP0Kl6cdcJtKUEmrEGVywe8 X-Received: by 10.194.89.170 with SMTP id bp10mr49821089wjb.7.1448812107357; Sun, 29 Nov 2015 07:48:27 -0800 (PST) Received: from localhost ([112.65.63.98]) by smtp.gmail.com with ESMTPSA id m16sm17300820wmb.13.2015.11.29.07.48.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Nov 2015 07:48:26 -0800 (PST) Date: Sun, 29 Nov 2015 18:48:29 -0500 From: Jianbo Liu To: Jerin Jacob Message-ID: <20151129234829.GA2913@qq.com> References: <1448631268-10692-1-git-send-email-jerin.jacob@caviumnetworks.com> <1448631268-10692-3-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448631268-10692-3-git-send-email-jerin.jacob@caviumnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/2] config: disable CONFIG_RTE_SCHED_VECTOR for arm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2015 15:48:27 -0000 On Fri, Nov 27, 2015 at 07:04:28PM +0530, Jerin Jacob wrote: > Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR > does support only SSE intrinsic, so disable it till we have neon support. > > Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config") > > Signed-off-by: Jerin Jacob > --- > config/common_arm64 | 1 + > config/defconfig_arm-armv7a-linuxapp-gcc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/config/common_arm64 b/config/common_arm64 > index 5e5e303..d6a9cb9 100644 > --- a/config/common_arm64 > +++ b/config/common_arm64 > @@ -46,3 +46,4 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n > CONFIG_RTE_LIBRTE_LPM=n > CONFIG_RTE_LIBRTE_TABLE=n > CONFIG_RTE_LIBRTE_PIPELINE=n > +CONFIG_RTE_SCHED_VECTOR=n > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc > index 82143af..9924ff9 100644 > --- a/config/defconfig_arm-armv7a-linuxapp-gcc > +++ b/config/defconfig_arm-armv7a-linuxapp-gcc > @@ -57,6 +57,7 @@ CONFIG_RTE_LIBRTE_ACL=n > CONFIG_RTE_LIBRTE_LPM=n > CONFIG_RTE_LIBRTE_TABLE=n > CONFIG_RTE_LIBRTE_PIPELINE=n > +CONFIG_RTE_SCHED_VECTOR=n > > # cannot use those on ARM > CONFIG_RTE_KNI_KMOD=n > -- > 2.1.0 > Hi Jerin, In this way, we still have to modify two files each time a new feature is added but not verified on ARM architectures. Since disabling those drivers and libs are common for both armv7 and armv8, can you put them in one config file, for example: common_arm? It is not like common_arm64, which is solely for armv8 platform. Actually, the arm64 common config is defconfig_arm64-armv8a-linuxapp-gcc you can include it in the thunderx or xgene1 config files respectively, and overriding some special config if needed. On the other hand, If we support the features in the future by replacing SSE intrinsic with NEON, we just need to remove the lines in one place. Regards, Jianbo