From: Stephen Hemminger <stephen@networkplumber.org>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40evf: fix mac deletion when stop dev
Date: Mon, 30 Nov 2015 08:33:00 -0800 [thread overview]
Message-ID: <20151130083300.75ba06bc@xeon-e3> (raw)
In-Reply-To: <1448855649-24658-1-git-send-email-jingjing.wu@intel.com>
On Mon, 30 Nov 2015 11:54:09 +0800
Jingjing Wu <jingjing.wu@intel.com> wrote:
> + (void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr,
> + sizeof(mac_addr.addr_bytes))
Please don't add useless (void) cast.
I haven't seen that since lint on Unix.
next prev parent reply other threads:[~2015-11-30 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 3:54 Jingjing Wu
2015-11-30 5:17 ` Zhang, Helin
2015-11-30 5:48 ` Wu, Jingjing
2015-11-30 16:33 ` Stephen Hemminger [this message]
2015-12-06 21:34 ` Thomas Monjalon
2015-12-06 21:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130083300.75ba06bc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).