From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id ADDF469C8 for ; Mon, 30 Nov 2015 17:32:50 +0100 (CET) Received: by pabfh17 with SMTP id fh17so195174864pab.0 for ; Mon, 30 Nov 2015 08:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=bNj7qdJPEs3zTBZVctoRWcXqEw9w+zsXxV2BY8W1PhA=; b=pSBy/mGSHtnULfQwdUX1wGOwNAIZAnLjPJ4ISUWD4j7uq9b+xEVNy7BVHcLvYJJWvd 8eFvktz+5gIeHftLb4cjGljIFYzAGT39nqBOqWbKLS+2bTWMGeZSCBuHMrSpWQzhv50y vTHz8eI73ojIIC7j/YfTHzB3Z44Vc6dyCKez3rD0UuA+pBEUZuVgecGxPyCQpfJjersH 9wFNumBF6Wsf6f9qzS1OT4MgrM4EG1ZvqrSbRpbq5137RiuuXfdHKfpMS4H73T3ci3EY 2jRTBV6ajPnYGKhPOQPs1uTMtN4chOb56N6xkVJBHeJAjgEOnFea9EoKC3g5MPKWpMVt DPaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=bNj7qdJPEs3zTBZVctoRWcXqEw9w+zsXxV2BY8W1PhA=; b=jPcKEAkP5eWpaWFz68a6KnVP1x9AQ3jqo7jy4hkCK2ImbwdscJQPgWCMOsHKgNHOkp 13/lUQzcDoeEsrXdDwg+4G4tYiZhhmICj9QMc+Fg9CzooeSWYHFbr51blYmQeUl0+lRM Vbo/sgxua8bSLw9KcWXvRYRr9nyDc3u3YoDM74awxnsn+XDpuQGvstlOrg02ZrLk9ka+ vKv0zrpcOuOotgNQxfozGG5VBNswJH9O8l1H86s+DUvdcZPqskk0alDHbwQvlo8BOnVH L1iTriAZR87am/smhBiaiU9UGDpoc0FZqxyK8AqI0hTqpfR/Nq0/A1qIBis9nF9OllBy I+dA== X-Gm-Message-State: ALoCoQmlUhJVRaXztNPFraPDcfDOMwU94aZEDsSrA4FcSbba2HVVQLF6x7GFrO5o4OTA5fqp9J8A X-Received: by 10.98.73.13 with SMTP id w13mr71187676pfa.72.1448901170076; Mon, 30 Nov 2015 08:32:50 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id t71sm52246183pfi.60.2015.11.30.08.32.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Nov 2015 08:32:49 -0800 (PST) Date: Mon, 30 Nov 2015 08:33:00 -0800 From: Stephen Hemminger To: Jingjing Wu Message-ID: <20151130083300.75ba06bc@xeon-e3> In-Reply-To: <1448855649-24658-1-git-send-email-jingjing.wu@intel.com> References: <1448855649-24658-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40evf: fix mac deletion when stop dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 16:32:50 -0000 On Mon, 30 Nov 2015 11:54:09 +0800 Jingjing Wu wrote: > + (void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr, > + sizeof(mac_addr.addr_bytes)) Please don't add useless (void) cast. I haven't seen that since lint on Unix.