From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 054AE8DB1
 for <dev@dpdk.org>; Wed,  2 Dec 2015 11:55:11 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 02 Dec 2015 02:55:12 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,372,1444719600"; d="scan'208";a="864917245"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by fmsmga002.fm.intel.com with ESMTP; 02 Dec 2015 02:55:10 -0800
Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com
 [10.237.217.37])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 tB2At9ZB029161; Wed, 2 Dec 2015 10:55:09 GMT
Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1])
 by sivlogin002.ir.intel.com with ESMTP id tB2At9Ig025604;
 Wed, 2 Dec 2015 10:55:09 GMT
Received: (from fyigit@localhost)
	by sivlogin002.ir.intel.com with œ id tB2At9gk025600;
	Wed, 2 Dec 2015 10:55:09 GMT
X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to
 ferruh.yigit@intel.com using -f
Date: Wed, 2 Dec 2015 10:55:09 +0000
From: "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
Message-ID: <20151202105509.GB25180@sivlogin002.ir.intel.com>
Mail-Followup-To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
References: <1448473001-19725-1-git-send-email-ferruh.yigit@intel.com>
 <1448473264-20907-1-git-send-email-ferruh.yigit@intel.com>
 <7ADD74816B4C8A45B56203CBA65FE5A61D98EDFB@IRSMSX107.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7ADD74816B4C8A45B56203CBA65FE5A61D98EDFB@IRSMSX107.ger.corp.intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] examples/bond: fix bsd compile error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Dec 2015 10:55:12 -0000

On Thu, Nov 26, 2015 at 09:52:15AM +0000, Mrzyglod, DanielX T wrote:
> >-----Original Message-----
> >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> >Sent: Wednesday, November 25, 2015 6:41 PM
> >To: dev@dpdk.org
> >Subject: [dpdk-dev] [PATCH v2] examples/bond: fix bsd compile error
> >
> >Error:
> >== bond
> >  CC main.o
> >/.../examples/bond/main.c:431:24: error: use of undeclared identifier 'AF_INET'
> >        if (res->ip.family == AF_INET)
> >                              ^
> >1 error generated.
> >/.../mk/internal/rte.compile-pre.mk:126: recipe for target 'main.o' failed
> >
> >AF_INET defined in sys/socket.h
> >
> >This header included for Linux:
> >. /<snip>/include/rte_ip.h
> >.. /usr/include/netinet/in.h
> >... /usr/include/sys/socket.h
> >
> >But not for FreeBSD:
> >. /<snip>/include/rte_ip.h
> >.. /usr/include/netinet/in.h
> >... /usr/include/machine/endian.h
> >... /usr/include/netinet6/in6.h
> >. /<snip>/include/rte_tcp.h
> >
> >Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >---
> > examples/bond/main.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/examples/bond/main.c b/examples/bond/main.c
> >index 4622283..19f4f05 100644
> >--- a/examples/bond/main.c
> >+++ b/examples/bond/main.c
> >@@ -45,6 +45,7 @@
> > #include <termios.h>
> > #include <unistd.h>
> > #include <pthread.h>
> >+#include <sys/socket.h>
> >
> > #include <rte_common.h>
> > #include <rte_log.h>
> >--
> >2.5.0
> 
> Acked-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

Self NACK, in favour of http://dpdk.org/dev/patchwork/patch/9130/
I will update pathwork.

Thanks,
ferruh