From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: [dpdk-dev] Aligning net/ethernet.h and rte_ether.h
Date: Wed, 2 Dec 2015 11:45:58 -0800 [thread overview]
Message-ID: <20151202114558.7980fad9@xeon-e3> (raw)
The two header files net/ethenet.h and rte_ether.h are source
incompatiable right now. They both define a bunch of constants
and struct ether_addr; the effective values are the same but
the structure element name is different.
/usr/include/net/ether.h
/* This is a name for the 48 bit ethernet address available on many
systems. */
struct ether_addr
{
u_int8_t ether_addr_octet[ETH_ALEN];
} __attribute__ ((__packed__));
lib/librte_ether/rte_ether.h
struct ether_addr {
uint8_t addr_bytes[ETHER_ADDR_LEN]; /**< Address bytes in transmission order */
} __attribute__((__packed__));
I would like to just have rte_ether.h include netinet/ether.h
to get rid of the useless duplication, and fix all the code in DPDK.
But this will break out-of-tree source compatibility so best to
wait for DPDK 2.3. Is there a good place to put this in 2.2 release notes?
next reply other threads:[~2015-12-02 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 19:45 Stephen Hemminger [this message]
2015-12-02 21:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202114558.7980fad9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).