From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id DA1D68E6C for ; Wed, 2 Dec 2015 14:46:18 +0100 (CET) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3p9hQy57HFzSt; Wed, 2 Dec 2015 14:46:18 +0100 (CET) Date: Wed, 2 Dec 2015 14:43:40 +0100 From: Jan Viktorin To: Jerin Jacob Message-ID: <20151202144340.6b846d81@pcviktorin.fit.vutbr.cz> In-Reply-To: <1448904253-12929-3-git-send-email-jerin.jacob@caviumnetworks.com> References: <1448904253-12929-1-git-send-email-jerin.jacob@caviumnetworks.com> <1448904253-12929-3-git-send-email-jerin.jacob@caviumnetworks.com> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/3] lpm: add support for NEON X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 13:46:19 -0000 On Mon, 30 Nov 2015 22:54:12 +0530 Jerin Jacob wrote: > enabled CONFIG_RTE_LIBRTE_LPM, CONFIG_RTE_LIBRTE_TABLE, > CONFIG_RTE_LIBRTE_PIPELINE libraries for arm64. > > TABLE, PIPELINE libraries were disabled due to LPM library dependency. > > Signed-off-by: Jerin Jacob > --- > app/test/test_lpm.c | 10 +- > config/defconfig_arm64-armv8a-linuxapp-gcc | 3 - > lib/librte_lpm/Makefile | 3 + > lib/librte_lpm/rte_lpm.h | 5 + > lib/librte_lpm/rte_lpm_neon.h | 172 +++++++++++++++++++++++++++++ > 5 files changed, 185 insertions(+), 8 deletions(-) > create mode 100644 lib/librte_lpm/rte_lpm_neon.h > > [snip] > > # this lib needs eal > DEPDIRS-$(CONFIG_RTE_LIBRTE_LPM) += lib/librte_eal > diff --git a/lib/librte_lpm/rte_lpm.h b/lib/librte_lpm/rte_lpm.h > index c299ce2..12b75ce 100644 > --- a/lib/librte_lpm/rte_lpm.h > +++ b/lib/librte_lpm/rte_lpm.h > @@ -361,6 +361,9 @@ rte_lpm_lookup_bulk_func(const struct rte_lpm *lpm, const uint32_t * ips, > /* Mask four results. */ > #define RTE_LPM_MASKX4_RES UINT64_C(0x00ff00ff00ff00ff) > > +#if defined(RTE_ARCH_ARM64) > +#include "rte_lpm_neon.h" > +#else > /** > * Lookup four IP addresses in an LPM table. > * > @@ -473,6 +476,8 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, __m128i ip, uint16_t hop[4], > hop[3] = (tbl[3] & RTE_LPM_LOOKUP_SUCCESS) ? (uint8_t)tbl[3] : defv; > } > > +#endif > + I would separate the SSE implementation into its own file as well. Otherwise, I like this patch. I hope to be able to test it soon. > [snip] -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic