From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id EBD74568A
 for <dev@dpdk.org>; Thu,  3 Dec 2015 02:59:27 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga102.jf.intel.com with ESMTP; 02 Dec 2015 17:59:27 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,375,1444719600"; 
   d="scan'208";a="6561416"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by fmsmga004.fm.intel.com with ESMTP; 02 Dec 2015 17:59:21 -0800
Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com
 [10.237.217.37])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 tB31xKLV023671; Thu, 3 Dec 2015 01:59:20 GMT
Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1])
 by sivlogin002.ir.intel.com with ESMTP id tB31xKwZ025449;
 Thu, 3 Dec 2015 01:59:20 GMT
Received: (from fyigit@localhost)
	by sivlogin002.ir.intel.com with œ id tB31xKcZ025445;
	Thu, 3 Dec 2015 01:59:20 GMT
X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to
 ferruh.yigit@intel.com using -f
Date: Thu, 3 Dec 2015 01:59:19 +0000
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20151203015919.GA23772@sivlogin002.ir.intel.com>
Mail-Followup-To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
References: <1449105754-17136-1-git-send-email-ferruh.yigit@intel.com>
 <1744460.N1LazHY3fl@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1744460.N1LazHY3fl@xps13>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix compile error and ABI
	versioning	for combined shared library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 01:59:28 -0000

On Thu, Dec 03, 2015 at 02:36:53AM +0100, Thomas Monjalon wrote:
> Hi Ferruh,
> 
> Thanks for working on it.
> 
> 2015-12-03 01:22, Ferruh Yigit:
> > +ifeq ($(COMBINED_BUILD),1)
> >  include $(RTE_SDK)/mk/rte.sharelib.mk
> > +endif
> [...]
> >  	@if [ $@ = drivers -a $(CONFIG_RTE_BUILD_COMBINE_LIBS) = y ]; then \
> > -		$(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \
> > +		COMBINED_BUILD=1 $(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \
> 
> What is it fixing?
> The badly named sharelib is for combined build only.

lib/Makefile and drivers/net/Makefile includes sharelib.mk _always_, this flag is to include sharelib.mk only when we are compiling combined library.
Previously this inclusion was not problem because there was not common variable, now we start using common CPU_LDFLAGS variable and sharedlib.mk shouldn't included when not compiling for combined lib.

> 
> [...]
> > +FILES=$(find $RTE_SDK -name "*.map" | grep -v build)
> 
> The build dir is not always "build/"
> 
Thanks, I will fix this and send a new patch, I assume I can rely on "*_version.map" naming convention.