From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error
Date: Thu, 3 Dec 2015 14:17:37 +0800 [thread overview]
Message-ID: <20151203061737.GY2325@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1449093693-112570-1-git-send-email-jianfeng.tan@intel.com>
On Thu, Dec 03, 2015 at 06:01:33AM +0800, Jianfeng Tan wrote:
> This issue was discovered under the case of software vm2vm
> fowarding. When pkts are received from virtio device 0 and
> tx_route to virtio device 1, tx of device 0 is not updated.
>
> To fix this problem, we check each rx/tx branch to update
> stats. Besides, the stats are printed at a separated thread,
> so we design a mechanism to make sure unreasonable data will
> not show.
Fixing statistics for vm2vm case and designing a mechanism
to make sure unreasonable data will not sure are two different
things: they should be done in two different patches, but not
one.
So, again, please do not mix two (or more) things in one patch.
--yliu
next prev parent reply other threads:[~2015-12-03 6:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 22:32 [dpdk-dev] [PATCH] examples/vhost: add rate statistics for rx/tx and core Jianfeng Tan
2015-12-02 5:45 ` Yuanhan Liu
2015-12-02 22:01 ` [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error Jianfeng Tan
2015-12-03 6:17 ` Yuanhan Liu [this message]
2015-12-03 6:24 ` Tan, Jianfeng
2015-12-02 23:20 ` [dpdk-dev] [PATCH v3] " Jianfeng Tan
2015-12-03 6:28 ` Yuanhan Liu
2015-12-07 1:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203061737.GY2325@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).