From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C73815A6C for ; Thu, 3 Dec 2015 07:14:04 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 02 Dec 2015 22:14:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,376,1444719600"; d="scan'208";a="863619786" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga002.jf.intel.com with ESMTP; 02 Dec 2015 22:14:03 -0800 Date: Thu, 3 Dec 2015 14:17:37 +0800 From: Yuanhan Liu To: Jianfeng Tan Message-ID: <20151203061737.GY2325@yliu-dev.sh.intel.com> References: <1449009174-93334-1-git-send-email-jianfeng.tan@intel.com> <1449093693-112570-1-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449093693-112570-1-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 06:14:05 -0000 On Thu, Dec 03, 2015 at 06:01:33AM +0800, Jianfeng Tan wrote: > This issue was discovered under the case of software vm2vm > fowarding. When pkts are received from virtio device 0 and > tx_route to virtio device 1, tx of device 0 is not updated. > > To fix this problem, we check each rx/tx branch to update > stats. Besides, the stats are printed at a separated thread, > so we design a mechanism to make sure unreasonable data will > not show. Fixing statistics for vm2vm case and designing a mechanism to make sure unreasonable data will not sure are two different things: they should be done in two different patches, but not one. So, again, please do not mix two (or more) things in one patch. --yliu