From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: don't crash if one pci device fails
Date: Thu, 3 Dec 2015 10:02:07 +0000 [thread overview]
Message-ID: <20151203100207.GD7972@bricha3-MOBL3> (raw)
In-Reply-To: <1449106720-30430-1-git-send-email-stephen@networkplumber.org>
On Wed, Dec 02, 2015 at 05:38:40PM -0800, Stephen Hemminger wrote:
> If there is a failure to setup one pci device, there maybe other
> devices that can be initialized. Don't call rte_exit which
> is a forced crash, pass the error back to the
> application to decide what it wants to do.
>
> Might be good idea to return a positive value for the
> number of devices found, but that would break ABI.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
The return value from this function gets passed back to rte_eal_init() where
it will still cause an application to terminate. Therefore, I think the
commit message is a little misleading.
Otherwise all looks ok to me. Will help weed out multiple device failures on
a single pass too.
/Bruce
next prev parent reply other threads:[~2015-12-03 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 1:38 Stephen Hemminger
2015-12-03 10:02 ` Bruce Richardson [this message]
2015-12-03 10:08 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203100207.GD7972@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).