From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 20E41568A
 for <dev@dpdk.org>; Thu,  3 Dec 2015 11:02:10 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP; 03 Dec 2015 02:02:10 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,377,1444719600"; d="scan'208";a="852987863"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.61])
 by fmsmga001.fm.intel.com with SMTP; 03 Dec 2015 02:02:08 -0800
Received: by  (sSMTP sendmail emulation); Thu, 03 Dec 2015 10:02:07 +0025
Date: Thu, 3 Dec 2015 10:02:07 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Message-ID: <20151203100207.GD7972@bricha3-MOBL3>
References: <1449106720-30430-1-git-send-email-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449106720-30430-1-git-send-email-stephen@networkplumber.org>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: don't crash if one pci device fails
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 10:02:11 -0000

On Wed, Dec 02, 2015 at 05:38:40PM -0800, Stephen Hemminger wrote:
> If there is a failure to setup one pci device, there maybe other
> devices that can be initialized. Don't call rte_exit which
> is a forced crash, pass the error back to the
> application to decide what it wants to do.
> 
> Might be good idea to return a positive value for the
> number of devices found, but that would break ABI.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

The return value from this function gets passed back to rte_eal_init() where
it will still cause an application to terminate. Therefore, I think the 
commit message is a little misleading.

Otherwise all looks ok to me. Will help weed out multiple device failures on
a single pass too.

/Bruce