From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id C3D1C37A6
 for <dev@dpdk.org>; Thu,  3 Dec 2015 12:18:30 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 03 Dec 2015 03:18:30 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,377,1444719600"; d="scan'208";a="699424106"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by orsmga003.jf.intel.com with ESMTP; 03 Dec 2015 03:18:28 -0800
Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com
 [10.237.217.37])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 tB3BISXU002220; Thu, 3 Dec 2015 11:18:28 GMT
Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1])
 by sivlogin002.ir.intel.com with ESMTP id tB3BISoT015193;
 Thu, 3 Dec 2015 11:18:28 GMT
Received: (from fyigit@localhost)
	by sivlogin002.ir.intel.com with œ id tB3BIRYu015189;
	Thu, 3 Dec 2015 11:18:27 GMT
X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to
 ferruh.yigit@intel.com using -f
Date: Thu, 3 Dec 2015 11:18:27 +0000
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Message-ID: <20151203111827.GA11634@sivlogin002.ir.intel.com>
Mail-Followup-To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 dev@dpdk.org
References: <1449105754-17136-1-git-send-email-ferruh.yigit@intel.com>
 <CAATJJ0KytMmeL86cRQ+N8UeAbfJ9wc7MLLNYGsTk+jDQoaz=3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAATJJ0KytMmeL86cRQ+N8UeAbfJ9wc7MLLNYGsTk+jDQoaz=3Q@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix compile error and ABI
	versioning	for combined shared library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 11:18:31 -0000

On Thu, Dec 03, 2015 at 09:18:49AM +0100, Christian Ehrhardt wrote:
> Hi Ferruh,
> some minor bash improvements that could be made in the next revision:
> 
> On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > diff --git a/scripts/merge_maps.sh b/scripts/merge_maps.sh
> > new file mode 100755
> > index 0000000..bc40dc8
> > --- /dev/null
> > +++ b/scripts/merge_maps.sh
> > @@ -0,0 +1,29 @@
> > +#!/bin/sh
> > +
> > +FILES=$(find $RTE_SDK -name "*.map" | grep -v build)
> > +SYMBOLS=$(grep -h "{" $FILES | sort -u | sed 's/{//')
> 
> Guarding $RTE_SDK and $FILES with "" will help avoid some potential
> issues due to words splitting.
> 
> [...]
> > +               sed -n "/$s {/,/}/p" $f | sed '/^$/d' | grep -v global | grep -v local | sed '1d' | sed '$d'
> 
> As above with $f
> 
> [...]
> > +       if [ "$prev_sym" == "none" ]; then
> 
> Should be only one = as == is non standard and could fail in some environments.
> 

Thank you Christian, I will update accordingly.

Regards,
ferruh