From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C45238D86 for ; Fri, 4 Dec 2015 04:29:38 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 03 Dec 2015 19:29:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,378,1444719600"; d="scan'208";a="612298423" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by FMSMGA003.fm.intel.com with ESMTP; 03 Dec 2015 19:29:37 -0800 Date: Fri, 4 Dec 2015 11:29:53 +0800 From: Yuanhan Liu To: Stephen Hemminger Message-ID: <20151204032953.GC29571@yliu-dev.sh.intel.com> References: <1449194904-9626-1-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449194904-9626-1-git-send-email-stephen@networkplumber.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio: fix link state regression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 03:29:39 -0000 On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote: > Support for link state interrupt was broken on virtio by > > commit bda66c418c85 ("ethdev: add device fields from PCI layer") > > This is caused because the actual value of drv_flags is not set > until after the resource_init has figured out whether it is using > UIO or direct I/O instructions. > > Signed-off-by: Stephen Hemminger > --- > There maybe other drivers with the same problem. It would have > been better to move the structure elements (and break ABI) rather > than assume it safe to copy them. Better to fail compiling. I see no patch content. --yliu