From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com
 [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 334C92A1A
 for <dev@dpdk.org>; Mon,  7 Dec 2015 21:55:16 +0100 (CET)
Received: by pacej9 with SMTP id ej9so130677973pac.2
 for <dev@dpdk.org>; Mon, 07 Dec 2015 12:55:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=SU4nJG3YQ6dFOFFjgyHl/jUiz6+aXSQuRjPQNQhVvpk=;
 b=Tb3InSIJhPeKuiEAjzX/wfBreG0mLYuxVOpZCFQa8yxGp1l4xM3IriHT2fJlq4G08u
 SAYFBmUEFLWqgZTbqBhxFZ6qfK2RG6SDoiTJOg6nvms5tI0X7K5gnp/G14smlMdLuniH
 jDIwoT3i+3R21NuCr8w7SGR/kljDADv8EtVWsZNHYYumAAzrMfuCwgp42bm8ZKrUuzcP
 28bJTlmyrpLRCqw7lYRo6IE2gNRIF5fxxD8XiWczq9RJvHTe/7IK3InuXhyyU33FeIPV
 ffpatVe2X0b4Pzv6o7xTSCsT4p3NagRZ6Nx/eZj9XF5zeXhuc6LcxFSM8bbvWKi5q4CY
 BJKA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=SU4nJG3YQ6dFOFFjgyHl/jUiz6+aXSQuRjPQNQhVvpk=;
 b=NjKV5VKqnO+gOK8+4ojZRUOurx8YT2LCHObh0B9LWbN+Lctn5S3Htm8j3YsV7WvtOj
 rKRD8cyCbYLFV7dnTS8GVEKy94o41Cxzh5WVjq3/AuV3EU+aEHLqxQ6JxT4AqDB+FQjQ
 /naR4/2JBeDr2zZzZl/jT1+Y55SrX2RIFNmB7tCYusCh3pp7V4qjpVYAZFzwv0qJSarQ
 u6DkUtFM0Y+FOwLy2aZSANEOVQiBlGAJ1PZ8XddI3yVboDieKk5e2fmg7KVl7Nq48dJu
 rTQ/y9QoPIFJr02+uVb4g/3hjLiaI8fycvdDklR12dG+wUtE1/lkQwUmvW93M/piGYt+
 54yA==
X-Gm-Message-State: ALoCoQliEUA7nemEb97w/ZYeoFXVjtrxN2Tcmryu55tjtjW/AmmzmPG3uelFq8kEq52J39jpaQi1
X-Received: by 10.66.221.42 with SMTP id qb10mr46290253pac.51.1449521715519;
 Mon, 07 Dec 2015 12:55:15 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id w20sm36474279pfi.55.2015.12.07.12.55.14
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 07 Dec 2015 12:55:15 -0800 (PST)
Date: Mon, 7 Dec 2015 12:55:24 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>
Message-ID: <20151207125524.1095237c@xeon-e3>
In-Reply-To: <1449513365-22282-2-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
References: <1449507460-32038-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
 <1449513365-22282-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
 <1449513365-22282-2-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/2] eal/linux: Add support for handling
 built-in kernel modules
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2015 20:55:16 -0000

On Mon, 7 Dec 2015 19:36:05 +0100
Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com> wrote:

> +	/* Check if there is sysfs mounted */
> +	if (stat("/sys/module", &st) != 0) {
> +		RTE_LOG(DEBUG, EAL, "Open /sys/module failed: %s\n",
> +			strerror(errno));
>  		return -1;
>  	}

This check is useless.
If /sys/module does not exist then /sys/module/XXX won't exist either.