From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, nlaw@brocade.com
Subject: Re: [dpdk-dev] [PATCH] vhost: don't stall if guest is slow
Date: Tue, 8 Dec 2015 11:12:08 +0800 [thread overview]
Message-ID: <20151208031208.GJ29571@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <3746283.SiKfvnY0NL@xps13>
On Tue, Dec 08, 2015 at 03:30:43AM +0100, Thomas Monjalon wrote:
> 2015-12-08 10:23, Yuanhan Liu:
> > On Mon, Dec 07, 2015 at 04:50:21PM -0800, Stephen Hemminger wrote:
> > > When guest is booting (or any othertime guest is busy) it is possible
> > > for the small receive ring (256) to get full. If this happens the
> > > vhost library should just return normally. It's current behavior
> > > of logging just creates massive log spew/overflow which could even
> > > act as a DoS attack against host.
> > >
> > > Reported-by: Nathan Law <nlaw@brocade.com>
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Yuanhan, please what is your opinion about the balance benefit/risk
> of this patch for 2.2?
Thomas,
I agree with Stephen that such log is not necessary as it's a fair
normal case. However, I see no too much benefit/risk for 2.2: it
just removes a debug log after all.
--yliu
next prev parent reply other threads:[~2015-12-08 3:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 0:50 Stephen Hemminger
2015-12-08 2:23 ` Yuanhan Liu
2015-12-08 2:30 ` Thomas Monjalon
2015-12-08 3:12 ` Yuanhan Liu [this message]
2015-12-09 20:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208031208.GJ29571@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=nlaw@brocade.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).