From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
[209.85.220.53]) by dpdk.org (Postfix) with ESMTP id E400B37A6
for <dev@dpdk.org>; Tue, 8 Dec 2015 17:49:55 +0100 (CET)
Received: by pacej9 with SMTP id ej9so14631555pac.2
for <dev@dpdk.org>; Tue, 08 Dec 2015 08:49:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:subject:message-id:mime-version:content-type
:content-transfer-encoding;
bh=dTZI9DERKmXEUoHEs4BKX8/HX0m930vVlHHUnzbTJkA=;
b=SFzSXM8EPYYn+9EDwU1p8kGTfd+rFzmiBLGN2H8M40uWxiOMojFSMW19DxF6ZDaBIk
rQhdz932513/gpiXCrrzYm5hRDm1k44fy7Y7EIKTlyTbrkHj+sqaDqe/p5sST4ObYyqM
y8nxZndeCJ4FGzxhKKzdlkN4n97iW6OfDD72mNLagx1D7ZFkGvouFEWH0XRGxUYYN5FU
sKYuo06sskVX3m7Sz85UNBKbUaJg0exUkfAmILzkzNH+iVNlomnzatH1Ch8oVMKepQft
nhFnlMYxAC/zFjaHWgNTENf1B5Qw3+TRxmF2NPCSLDCuW1I1hjf/SL1tMk695a1cv/Vy
GPSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:date:from:to:subject:message-id:mime-version
:content-type:content-transfer-encoding;
bh=dTZI9DERKmXEUoHEs4BKX8/HX0m930vVlHHUnzbTJkA=;
b=AQkfnrJ4x615ec9pIegw4hG5r1dtZ9bdHVqfZETRyZgjLgJSGSQ+u6Cfnst1FSiykm
R8KDcr7MeF4hf1udXnUDnXWy7CVwjx22BdK569gSbHUtCpqHO/bB3Xpos2a9RWbe6LVL
5GvcY4PxsP+JMOnQJaoECbMzHa+tJm/Lo76IHy2orEXOGdzgRvSfmjvdR7jUK5gadpAK
DBWFrCgJhWthROUeDjZabgGoz0l8oi5MC+lh2I4Ed2RL7Evs0W/zE/Wkm7aZsZil1j3J
2YlGgrWf7VT/KE5NOwAY15Ecfo3jjyNuTjWMoOqheq+7taNaLro4v/q5Djwxj48OPgU3
COnQ==
X-Gm-Message-State: ALoCoQmONyOdefW3r271COixR25nh2PjglBuOVM/ubRW+3anTa2ta/RdmYjDbcP9lHUPp+cfwTOSeKKuIpIRKmN+a3RQEDJGvA==
X-Received: by 10.67.5.164 with SMTP id cn4mr1162769pad.141.1449593395166;
Tue, 08 Dec 2015 08:49:55 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
[50.53.82.155])
by smtp.gmail.com with ESMTPSA id tb8sm5985627pab.22.2015.12.08.08.49.54
for <dev@dpdk.org>
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 08 Dec 2015 08:49:54 -0800 (PST)
Date: Tue, 8 Dec 2015 08:50:04 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Message-ID: <20151208085004.2d4440f5@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] New Coverity warnings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 16:49:56 -0000
*** CID 120410: Error handling issues (CHECKED_RETURN)
/examples/l2fwd-keepalive/main.c: 571 in dead_core()
565
566 static void
567 dead_core(__attribute__((unused)) void *ptr_data, const int id_core)
568 {
569 printf("Dead core %i - restarting..\n", id_core);
570 if (rte_eal_get_lcore_state(id_core) == FINISHED) {
>>> CID 120410: Error handling issues (CHECKED_RETURN)
>>> Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).
571 rte_eal_wait_lcore(id_core);
572 rte_eal_remote_launch(l2fwd_launch_one_lcore, NULL, id_core);
573 } else {
574 printf("..false positive!\n");
575 }
576 }
** CID 37790: Error handling issues (CHECKED_RETURN)
/examples/bond/main.c: 593 in cmd_stop_parsed()
________________________________________________________________________________________________________
*** CID 37790: Error handling issues (CHECKED_RETURN)
/examples/bond/main.c: 593 in cmd_stop_parsed()
587 "lcore_main not running on core:%d\n",
588 global_flag_stru_p->LcoreMainCore);
589 rte_spinlock_unlock(&global_flag_stru_p->lock);
590 return;
591 }
592 global_flag_stru_p->LcoreMainIsRunning = 0;
>>> CID 37790: Error handling issues (CHECKED_RETURN)
>>> Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).
593 rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
594 cmdline_printf(cl,
595 "lcore_main stopped on core:%d\n",
596 global_flag_stru_p->LcoreMainCore);
597 rte_spinlock_unlock(&global_flag_stru_p->lock);
598 }
** CID 37789: Error handling issues (CHECKED_RETURN)
/examples/bond/main.c: 631 in cmd_quit_parsed()
________________________________________________________________________________________________________
*** CID 37789: Error handling issues (CHECKED_RETURN)
/examples/bond/main.c: 631 in cmd_quit_parsed()
625 global_flag_stru_p->LcoreMainCore);
626 rte_spinlock_unlock(&global_flag_stru_p->lock);
627 cmdline_quit(cl);
628 return;
629 }
630 global_flag_stru_p->LcoreMainIsRunning = 0;
>>> CID 37789: Error handling issues (CHECKED_RETURN)
>>> Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times).
631 rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
632 cmdline_printf(cl,
633 "lcore_main stopped on core:%d\n",
634 global_flag_stru_p->LcoreMainCore);
635 rte_spinlock_unlock(&global_flag_stru_p->lock);
636 cmdline_quit(cl);