From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 223C43787 for ; Wed, 9 Dec 2015 22:57:53 +0100 (CET) Received: by pabur14 with SMTP id ur14so36102540pab.0 for ; Wed, 09 Dec 2015 13:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=DTfkzZ2vWV/dZ+70KrodlKcnnW9SRMMeeKzTf9oq3Ag=; b=gojntXqwdn2F8zx2q8lUeOWgNPRWGOdUp47GfLJoOf4OVa/JYI6aU2Kq6YdRjVQ2Ae E0xEKt8nL3eapsqWwLL42s7ghZ3FZs1fRRXqZfMtsFrBasVDGP0CVfgwNacthLHME4Q1 PNFQAl+HAgRglAP1QK8rUg6kLShwuVTalNsgiVKCADn4M45pycwjlS/As43GN+aYMDF9 AfYI+nFJ6RmKvcsTci78+dlX9nH47G9jontIi90DhguAyFA1i28VfmFqUOsY2YJEr9Xp AmqTXizN8AYu756Rs9uEC8pSLgbF0+ZPxlbtB0seFru2vFQIs7By6mEAUB1ALrwoXcUc QOpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=DTfkzZ2vWV/dZ+70KrodlKcnnW9SRMMeeKzTf9oq3Ag=; b=AXU/tjRbKyIIlT/siSPo2i6Zd33BAzGOKwwCcf6c5FR8Ke7LWTC1IXjNtlEDfBtoet XnKXfRqzZSVr0l/RIVRiAgOfVegc3rj5BETnW4yfpOSKMM5unltQW+cp0oL40kGU7xZf rLGbXoNbacD+3wW/HD/uh5SBM4UvG6ci2eCqqzX0zoSsmKK2PKGes6zxCMuF6mAmMXqJ jvTSVKGJBJcFsB83IY/L+Sxez08C4Y7WZGJCsSk2HBnYi0wrO65w4LlzpGJnFjBZIVzM +yT/SLugmXCmCfCCBVSpkQ70w4Jr4oAyz4+t5ulHH2oZF1tPYHxGmE9aTZf/S44QNXRT lDQA== X-Gm-Message-State: ALoCoQlXxPoK46GDpj+BinXUEGg2OQTyY9utfMCVSnmR23UQweY4ikaI7fqlprGDqVjCACmHv40AGrgW0GDDmdrjRUuXkf7JAg== X-Received: by 10.67.5.2 with SMTP id ci2mr11446287pad.47.1449698272534; Wed, 09 Dec 2015 13:57:52 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id m20sm13742186pfi.80.2015.12.09.13.57.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2015 13:57:52 -0800 (PST) Date: Wed, 9 Dec 2015 13:58:01 -0800 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20151209135801.17965487@xeon-e3> In-Reply-To: <2562631.e9AmeysRzG@xps13> References: <1449683756-13381-1-git-send-email-stephen@networkplumber.org> <2562631.e9AmeysRzG@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Avi Kivity , Alex Williamson Subject: Re: [dpdk-dev] [PATCH] vfio: support iommu group zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 21:57:53 -0000 On Wed, 09 Dec 2015 22:12:33 +0100 Thomas Monjalon wrote: > 2015-12-09 09:55, Stephen Hemminger: > > The current implementation of VFIO will not with the new no-IOMMU mode > > in 4.4 kernel. The original code assumed that IOMMU group zero would > > never be used. Group numbers are assigned starting at zero, and up > > until now the group numbers came from the hardware which is likely > > to use group 0 for system devices that are not used with DPDK. > > > > The fix is to allow 0 as a valid group and rearrange code > > to split the return value from the group value. > > > > Signed-off-by: Stephen Hemminger > > --- > > Why was this ignored? It was originally sent on 26 Oct 15 back > > when IOMMU discussion was lively. > > There was no review of this patch. > The patch has been marked as deferred recently when it was too late > to do such feature changes in DPDK code: > http://dpdk.org/dev/patchwork/patch/8035/ This is why as a fallback the MAINTAINER has to review the patch or direct a sub-maintainer to do it. I think almost 2 months is plenty of time for review. Another alternative policy is to have a "default yes" policy such that if there are no objections or discussion things that are submitted early just go in (that is what ZeroMQ does). http://rfc.zeromq.org/spec:22 * Maintainers SHOULD NOT merge their own patches except in exceptional cases, such as non-responsiveness from other Maintainers for an extended period (more than 1-2 days). * Maintainers SHALL NOT make value judgments on correct patches. * Maintainers SHALL merge correct patches from other Contributors rapidly. * Maintainers SHOULD ask for improvements to incorrect patches and SHOULD reject incorrect patches if the Contributor does not respond constructively. * Any Contributor who has value judgments on a correct patch SHOULD express these via their own patches. * Maintainers MAY commit changes to non-source documentation directly to the project.