From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 125675A30 for ; Wed, 9 Dec 2015 17:53:51 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 09 Dec 2015 08:53:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,404,1444719600"; d="scan'208";a="837767746" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63]) by orsmga001.jf.intel.com with SMTP; 09 Dec 2015 08:53:47 -0800 Received: by (sSMTP sendmail emulation); Wed, 09 Dec 2015 16:53:45 +0025 Date: Wed, 9 Dec 2015 16:53:45 +0000 From: Bruce Richardson To: "Van Haaren, Harry" Message-ID: <20151209165344.GA4724@bricha3-MOBL3> References: <1449678215-25698-1-git-send-email-harry.van.haaren@intel.com> <22661588.S5N3t0Qb91@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] doc: add patch submit cheatsheet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 16:53:52 -0000 On Wed, Dec 09, 2015 at 04:47:42PM +0000, Van Haaren, Harry wrote: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > It would be better with a colon: > > Fixes: line > > Ok, will send a v2 with that fix. > > > > git send-email -N --to > > Why -N? > > -N sets the Number of patches to send, when not sending .patch files but sending the latest commits of the current branch in git. > > Would you prefer if the sending of .patch files was documented? I'm indifferent - but learned the -N way first :) >>From my point of view, yes. I think using format-patch followed by a separate send-email is a better, and safer, workflow, as it allows multiple edits and checks of the patches before sending. /Bruce