From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong queue index for VIRTIO_PCI_QUEUE_SEL
Date: Thu, 10 Dec 2015 09:33:19 +0800 [thread overview]
Message-ID: <20151210013319.GO29571@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <4152327.aAbH2kO9Wx@xps13>
On Wed, Dec 09, 2015 at 09:09:27PM +0100, Thomas Monjalon wrote:
> 2015-12-08 11:05, Yuanhan Liu:
> > We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx,
> > but not vq->queue_id.
> >
> > vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(),
> > which always starts from 0 no matter which queue it is. However,
> > for virtio, even number is for RX queue, and odd number is for
> > TX queue.
> >
> > Fixes: 5382b188fb8a ("virtio: add queue release")
> >
> > Cc: Bernard Iremonger <bernard.iremonger@intel.com>
>
> Bernard was not CC'ed.
Weird, it was indeed in the CC list (in the patch I sent) on my
email client.
--yliu
prev parent reply other threads:[~2015-12-10 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 3:05 Yuanhan Liu
2015-12-09 20:09 ` Thomas Monjalon
2015-12-10 1:33 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210013319.GO29571@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).