From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4723B567E for ; Thu, 10 Dec 2015 02:32:14 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 09 Dec 2015 17:32:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,405,1444719600"; d="scan'208";a="870486920" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by fmsmga002.fm.intel.com with ESMTP; 09 Dec 2015 17:32:00 -0800 Date: Thu, 10 Dec 2015 09:33:19 +0800 From: Yuanhan Liu To: Thomas Monjalon Message-ID: <20151210013319.GO29571@yliu-dev.sh.intel.com> References: <1449543912-31066-1-git-send-email-yuanhan.liu@linux.intel.com> <4152327.aAbH2kO9Wx@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4152327.aAbH2kO9Wx@xps13> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong queue index for VIRTIO_PCI_QUEUE_SEL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 01:32:14 -0000 On Wed, Dec 09, 2015 at 09:09:27PM +0100, Thomas Monjalon wrote: > 2015-12-08 11:05, Yuanhan Liu: > > We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx, > > but not vq->queue_id. > > > > vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(), > > which always starts from 0 no matter which queue it is. However, > > for virtio, even number is for RX queue, and odd number is for > > TX queue. > > > > Fixes: 5382b188fb8a ("virtio: add queue release") > > > > Cc: Bernard Iremonger > > Bernard was not CC'ed. Weird, it was indeed in the CC list (in the patch I sent) on my email client. --yliu