From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: add patch submit cheatsheet
Date: Thu, 10 Dec 2015 09:37:57 +0800 [thread overview]
Message-ID: <20151210013757.GP29571@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20151209165344.GA4724@bricha3-MOBL3>
On Wed, Dec 09, 2015 at 04:53:45PM +0000, Bruce Richardson wrote:
> On Wed, Dec 09, 2015 at 04:47:42PM +0000, Van Haaren, Harry wrote:
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > It would be better with a colon:
> > > Fixes: line
> >
> > Ok, will send a v2 with that fix.
> >
> > > > git send-email -N --to
> > > Why -N?
> >
> > -N sets the Number of patches to send, when not sending .patch files but sending the latest commits of the current branch in git.
> >
> > Would you prefer if the sending of .patch files was documented? I'm indifferent - but learned the -N way first :)
>
> >From my point of view, yes. I think using format-patch followed by a separate
> send-email is a better, and safer, workflow, as it allows multiple edits and
> checks of the patches before sending.
+1
--yliu
next prev parent reply other threads:[~2015-12-10 1:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 16:23 Harry van Haaren
2015-12-09 16:40 ` Thomas Monjalon
2015-12-09 16:47 ` Van Haaren, Harry
2015-12-09 16:51 ` Thomas Monjalon
2015-12-09 16:53 ` Bruce Richardson
2015-12-10 1:37 ` Yuanhan Liu [this message]
2015-12-09 17:27 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2015-12-13 22:48 ` Thomas Monjalon
2015-12-14 10:03 ` [dpdk-dev] [PATCH v3] " Harry van Haaren
2015-12-14 22:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210013757.GP29571@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).