From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F3EF2559C for ; Thu, 10 Dec 2015 07:30:16 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 09 Dec 2015 22:30:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,407,1444719600"; d="scan'208";a="868598269" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga002.jf.intel.com with ESMTP; 09 Dec 2015 22:29:59 -0800 Date: Thu, 10 Dec 2015 14:31:18 +0800 From: Yuanhan Liu To: Santosh Shukla Message-ID: <20151210063118.GR29571@yliu-dev.sh.intel.com> References: <1449250519-28372-1-git-send-email-sshukla@mvista.com> <20151207021219.GE29571@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/6] Add virtio support in arm/arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 06:30:17 -0000 On Thu, Dec 10, 2015 at 11:46:50AM +0530, Santosh Shukla wrote: > On Tue, Dec 8, 2015 at 6:29 PM, Xie, Huawei wrote: > > > > > >> -----Original Message----- > >> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > >> Sent: Monday, December 07, 2015 10:12 AM > >> To: Santosh Shukla > >> Cc: dev@dpdk.org; thomas.monjalon@6wind.com; Xie, Huawei > >> Subject: Re: [PATCH 0/6] Add virtio support in arm/arm64 > >> > >> On Fri, Dec 04, 2015 at 11:05:13PM +0530, Santosh Shukla wrote: > >> > This patch set add basic infrastrucure to run virtio-net-pci pmd driver > >> for > >> > arm64/arm. Tested on ThunderX platfrom. Verified for existing dpdk(s) > >> test > >> > applications like: > >> > - ovs-dpdk-vhost-user: across the VM's, for the use-cases like > >> guest2guest and > >> > Host2Guest > >> > - testpmd application: Tested for max virtio-net-pci interface currently > >> > supported in kernel i.e. 31 interface. > >> > >> > >> Hi Santosh, > >> > >> Here is a quick notice that I don't have time to review your patches > >> this one or two weeks. Sorry for that. > >> > >> (Not quite sure Huawei has the bandwidth or not, btw) > > Sorry, just back from vocation. We will review your patch. > > Ping, > > I have started working on V2 patch set based on review comment so far > received. It would be great if I get your review comment too. > > Also few of my patch code base changes for V2 version gonna overlap > with Yuanhan latest virtio 1.0 patch set titled "[dpdk-dev] [PATCH 0/6 > for 2.3] initial virtio 1.0 enabling ", Specially patch 4 and 5. So I > would appreciate any review feedback. That avoid overlapping for me. > Some questions though: > - Shall I rebase Yuanhan's virtio 1.0 patch set, then start v2? By No, you should not develop v2 based on my virtio 1.0 support patchset; it's in a very rough state, and it will not be applied soon: it's for v2.3, and v2.2 is not relased yet. So, I would suggest you (always) to make patches based on the latest git: rebasing (if necessary) won't be too hard after all, especially for small patch set. > doing that I could leverage "viritio: switch to 64 bit features". In > this patch series, I did took care of 32 bit vs 64 bit changes for > arm64 case. I'd suggest you to send v2, with all comments addressed. I will try to find a time reviewing your patches next week, to see what I can help :) --yliu