From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shemming@Brocade.com> Received: from mx0b-000f0801.pphosted.com (mx0b-000f0801.pphosted.com [67.231.152.113]) by dpdk.org (Postfix) with ESMTP id 0E4E78E5A for <dev@dpdk.org>; Fri, 11 Dec 2015 17:48:13 +0100 (CET) Received: from pps.filterd (m0048192.ppops.net [127.0.0.1]) by mx0b-000f0801.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tBBGXumY000458; Fri, 11 Dec 2015 08:48:13 -0800 Received: from hq1wp-exmb11.corp.brocade.com ([144.49.131.13]) by mx0b-000f0801.pphosted.com with ESMTP id 1yqkeua458-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 11 Dec 2015 08:48:13 -0800 Received: from xeon-e3 (172.16.180.50) by Hq1wp-exmb11.corp.brocade.com (10.70.20.185) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Fri, 11 Dec 2015 08:48:10 -0800 Date: Fri, 11 Dec 2015 08:48:19 -0800 From: Stephen Hemminger <shemming@brocade.com> To: <dev@dpdk.org>, Helin Zhang <helin.zhang@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com> Message-ID: <20151211084819.2177795d@xeon-e3> In-Reply-To: <1447431013-23245-1-git-send-email-stephen@networkplumber.org> References: <1447431013-23245-1-git-send-email-stephen@networkplumber.org> Organization: Brocade MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.180.50] X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To Hq1wp-exmb11.corp.brocade.com (10.70.20.185) X-Proofpoint-Spam-Reason: safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.15.21, 1.0.33, 0.0.0000 definitions=2015-12-11_09:2015-12-11,2015-12-11,1970-01-01 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 ] ixgbe: speed up transmit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 11 Dec 2015 16:48:14 -0000 On Fri, 13 Nov 2015 08:10:13 -0800 Stephen Hemminger <stephen@networkplumber.org> wrote: > From: Stephen Hemminger <shemming@brocade.com> > > The freeing of mbuf's in ixgbe is one of the observable hot spots > under load. Optimize it by doing bulk free of mbufs using code similar > to i40e and fm10k. > > Drop the no longer needed micro-optimization for the no refcount flag. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> How come this patch got no review or comments? It gets a visible performance gain of up to 10% in some cases. I understand maintainers are busy with internal work, but they need to read mailing list as well.