From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0075.outbound.protection.outlook.com [157.56.111.75]) by dpdk.org (Postfix) with ESMTP id 524952716 for ; Mon, 14 Dec 2015 15:38:01 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (122.167.202.21) by BY1PR0701MB1721.namprd07.prod.outlook.com (10.162.111.140) with Microsoft SMTP Server (TLS) id 15.1.355.16; Mon, 14 Dec 2015 14:37:33 +0000 Date: Mon, 14 Dec 2015 20:07:18 +0530 From: Jerin Jacob To: Santosh Shukla Message-ID: <20151214143717.GD30309@localhost.localdomain> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-8-git-send-email-sshukla@mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1450098032-21198-8-git-send-email-sshukla@mvista.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.202.21] X-ClientProxiedBy: MA1PR01CA0044.INDPRD01.PROD.OUTLOOK.COM (25.164.116.144) To BY1PR0701MB1721.namprd07.prod.outlook.com (25.162.111.140) X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 2:NnDUm/xDOiqNVyzILcT8m8psyqfxEwUaLYYR/e2im4RhYzcLldk/unJOMCAg70JWgkS4+YMAJtp0pEUXcdIW8UgirLnBkuGm4wqI7NcRbi9cidmz9ZCcHRvGO9ks+HQxU6zwJ9W8hOqxgVxmPhNwsA==; 3:TW2uJa9JTFRuXnDmpmD8V7MfQ5hfeUt2CFNOhyeUGQBCSh8semimE9IdBtYweRNcBCp3wzJfykqJlHmgtemFQUttko6uwOt3NF95d77tm484ELWLH37om52mvtllXY43; 25:DBVCV5LHCHKJPuSJB4+bAdHryHePazQceM2EHGlwe0DUJkkx6Njv7ydzSVL2iVysUC8xp7Stmau0HlDuo54qXPSU0LCWjQYekpgRGRjrJ1ta9ssmRHdKO3GiWm9B+kIIwSF/mYXd5zKZXBNa/eV4CPEhmU4pPfFsJQTTrF3JunmCnBV0jcpMcEZ3rwB8q+aU2ekL9Udi3S2esK718CWpgTF+RJnpSka9ffHr4kYtnBXxLcVGnpCq2hhuRIc8D42mCZIEWc+nMMN9T7b0IafiHw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1721; X-LD-Processed: 711e4ccf-2e9b-4bcf-a551-4094005b6194,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 20:glAuIG2DNbNCxeVECaryJ3VFl4dU2/U9V44gjB7ZN2t3Ko24eEppcRc4jSo9PjQEmSP93oaB52k3e0iFN39pHv3axjmDgY0rOILiwS+sK5OJwGIXi4ZwtyOUHyYdG/bVZFINgCMq8FNKJthRvwWsdcjSGSkOcmP3gW0zZfUMNR22GIzVXNrCKD4cwl1SBsOtu+u6Ato13BUUXYg+DG8MK0HOeZ7ct7JBUVd2D7DskuTtIdIZxru6hpYmcmtow1BBQtA+GhAj/sBsNXQkxhNrS6suCoeRwVw5s97Plr97AL2WH/TeIZSuWVCmN5aSmO8n4sa1U7pHhEBEr8qAIzNIprKh6vsriTReeLTLfZ4v9wr7Ce0lTQ37poWvc7UsKJ3tSCO55zZm6j5xGcwg99JgUqpJyhd+efvBK1fudfMdbk11jMqrhlmYjFlJF+EKKc5UzhHhcLRSEjUjsPIRLjr2ah4D1dQUHSAAaJZ9vRJhdc3EGM3Y1W0PtyXZP/0fWvLE5uOEQ/fYR6sVdecXGzwDGmXnXkdzCsO+5rAxlRG2XDjWuRGkSZc3gOwRY5GOcaBs2GSL5/4voeZTYCYJeJKO1vGNcEyuLTARYtnyvSQpQVE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046); SRVR:BY1PR0701MB1721; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1721; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 4:sux1AOAVcfoCJMAz05x8t17+LkP+z/amzJRKj44HUt1YaJ0XfzMBCfo4YQ2/6h4uRVIC7NPeFKh18QEZwfuetQnQePb6jw366fW0noqVqBUW29B2Xmo1XnBsjruDG6vRexdikF1eQmhOTgtSIDZjwhfdpqXTy7zjTDJMutOfEnA9NWxtZFRHhsioqQZxC1L5W7zYwOOdf2qKnee5WoWF7b6L70g3A0LL0x6mLL/u8zNR8UkaxSCFpW5TUNMJeY34F8oZeudnYKFt/BVikNNtO03ySudvXJ7n+hvloh3AIRt9S1Om3/chjsaljd3JlPBi3HywRf0hLyKmBWLiX3Qg3o5d9QRv2ulY6bE5gIF7p+roEQq2cYuu+9r9vwyemoVl X-Forefront-PRVS: 0790FB1F33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(199003)(24454002)(189002)(23726003)(1096002)(6116002)(40100003)(3846002)(1076002)(76176999)(586003)(50986999)(54356999)(46406003)(122386002)(42186005)(5008740100001)(86362001)(61506002)(5004730100002)(87976001)(19580405001)(19580395003)(189998001)(110136002)(106356001)(4001350100001)(81156007)(105586002)(50466002)(5001960100002)(97736004)(77096005)(47776003)(83506001)(92566002)(66066001)(2950100001)(97756001)(101416001)(33656002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1721; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1721; 23:+06Q1u03jlOrl8Puf0H7bZ50b3kigKLpAovAkAh?= =?us-ascii?Q?x5nQHmq/RhOqEZIDvP+/v3/PECZ+W7ICl7ErOCZVo1Pd04tbG28DfAo4ZkEM?= =?us-ascii?Q?VwpSXZKfqkLCqQWnapDUfxAeKLQi8lljyTrl/GyM3MeA65FARCZteilH9cgo?= =?us-ascii?Q?wIXE6hUmadTM1+v+pOJQuYNUPklrDUKEeqtIiuiT62O6LXPgZWWDz05JVxoc?= =?us-ascii?Q?mcYhxOgwInbQfKpnsDjKGdGem/Pr9V159TSBrY9SFBsGxWp2WKOctmpDFJpl?= =?us-ascii?Q?yQ8GbMfUF5RjKV5FYTzhzZogc6PsSa3gieM1yR4q85pfFMIcE2pjjcAS77t1?= =?us-ascii?Q?1MX2aufUxIkUNuW+jjIB7SD21VaCKFf0B/EVAV3s0CmhICBCbp7NsIOfweXf?= =?us-ascii?Q?1J5HTiyo6P6CuVCU7MWfT1wjl3PaKnkL6P+lLaeayjXT60qp8oX4vnSy47Ve?= =?us-ascii?Q?/SD50kbHOMmVTcQ4wyOIyo1LpPeY09QEW4i6gbZIc0kN0V/w8Kfb3feJqKkL?= =?us-ascii?Q?Y9ecucJxACHtoPb7qIdzQcaKBpeluej/vmZd2pecz5UAukYOjtCSwoOl1BRB?= =?us-ascii?Q?aslbTk/VkbhdUeWZ1EaYzEMpzcWDYo4t4UY6HhTGLPDhkJy09u6waS0LhXHU?= =?us-ascii?Q?ZFsIZKyFgzX8H4bwx/eoFKy0ZDBtg5voTojZFqr2LU1P18/eM4c5uWx2A/Rc?= =?us-ascii?Q?2s8ULeACOHEV7rPxVTGX0COL1H1UHTYAvS77zwlRpoFxlivnMwLQ/bJeLKzK?= =?us-ascii?Q?MOpDAKQlrJNGHY5XYWTP77c5S0z2vO0Vhpq4FWV7D+pj3ERg2n0BYJdRSMId?= =?us-ascii?Q?WhBL/eCr1iULMUGq5+nSAsTTy+9f32cka1v4eCWs+ggyNGJ7TlbhjQ0b9VGi?= =?us-ascii?Q?cGtWWxem/olJhblCyK4m2cdCEklRzC87RzlYBuBxU4Vj6J06fWU+LO4B5N8t?= =?us-ascii?Q?Bo37pmhsJ8CVo7AMcte93+OTuzWIU9xj5FFYkYMIvnFEFTX4is3CnRIWbjAD?= =?us-ascii?Q?yUJqXve2Zxwmco+N+st7NC/3+giHNnOWubw9TSrFINbQAl1cCqM6vREddeZK?= =?us-ascii?Q?zxL9644Pf5/8EXyfOkuS1OpeCXtZUjKnT8NCoqbSZnalC/STl0mzMn7KkITq?= =?us-ascii?Q?ulKtg3zhssucKMZmpIcsxEOrl1t+MOgA+?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 5:ziiNzSISfLoElwvBTqblRZY/WJFnZhZHmNcEF19jbKvFKjJ9WpTY0+gNH7Ccl3JXN5OSn01oOFyu5GymkCP7ouHAasSfR/6Rh1+amdMDPjaBaBp+ITQNO30yriiU3CAn6aHSOTfFt18jW6ARdulRUA==; 24:2PKyngsVm7+rRtZX4i1kMaacRLG9YQ4/xu2gHUF862zN598mgm9x76YKFzaOJqejGtKDPEyhq7ldLWV2Hs/m2ZC2OZipFDAJ3Ysun/AZx1M= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2015 14:37:33.9215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1721 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [ [PATCH v2] 07/13] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2015 14:38:01 -0000 On Mon, Dec 14, 2015 at 06:30:26PM +0530, Santosh Shukla wrote: > iopl() syscall not supported in linux-arm/arm64 so always return 0 value. > > Signed-off-by: Santosh Shukla > --- > lib/librte_eal/linuxapp/eal/eal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c > index 635ec36..2617037 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -716,6 +716,9 @@ rte_eal_iopl_init(void) > return -1; > return 0; > #else > +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) > + return 0; /* iopl syscall not supported for ARM/ARM64 */ I guess for other architectures also iopl not supported.I think better to move this function to eal. Else this function will return 'true' for ppc64 or have at least postive logic, #if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32) > +#endif > return -1; > #endif > } > -- > 1.7.9.5 >