From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 73580952 for ; Tue, 15 Dec 2015 15:28:10 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a8qaE-00072e-VY; Tue, 15 Dec 2015 09:28:08 -0500 Date: Tue, 15 Dec 2015 09:28:01 -0500 From: Neil Horman To: Panu Matilainen Message-ID: <20151215142801.GB25595@hmsreliant.think-freely.org> References: <1450176434-7213-1-git-send-email-thomas.monjalon@6wind.com> <1450176434-7213-2-git-send-email-thomas.monjalon@6wind.com> <566FFC81.2010601@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566FFC81.2010601@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Score: -1.0 (-) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: remove old flow director symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 14:28:10 -0000 On Tue, Dec 15, 2015 at 01:41:53PM +0200, Panu Matilainen wrote: > On 12/15/2015 12:47 PM, Thomas Monjalon wrote: > >The API has been removed but the symbols were still declared in the map. > > > >Fixes: a421b86a4a02 ("ethdev: remove old flow director API") > > > >Signed-off-by: Thomas Monjalon > >--- > > lib/librte_ether/rte_ether_version.map | 8 -------- > > 1 file changed, 8 deletions(-) > > > >diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map > >index 17a11c7..d8db24d 100644 > >--- a/lib/librte_ether/rte_ether_version.map > >+++ b/lib/librte_ether/rte_ether_version.map > >@@ -27,14 +27,6 @@ DPDK_2.2 { > > rte_eth_dev_count; > > rte_eth_dev_default_mac_addr_set; > > rte_eth_dev_detach; > >- rte_eth_dev_fdir_add_perfect_filter; > >- rte_eth_dev_fdir_add_signature_filter; > >- rte_eth_dev_fdir_get_infos; > >- rte_eth_dev_fdir_remove_perfect_filter; > >- rte_eth_dev_fdir_remove_signature_filter; > >- rte_eth_dev_fdir_set_masks; > >- rte_eth_dev_fdir_update_perfect_filter; > >- rte_eth_dev_fdir_update_signature_filter; > > rte_eth_dev_filter_ctrl; > > rte_eth_dev_filter_supported; > > rte_eth_dev_flow_ctrl_get; > > > > Good spotting. What did you use find these and the ones in eal? Just > thinking this seems like something that could and should be automated. > > - Panu - > You can likely do it with this command: nm -A ./*.o | grep | wc -l or something simmilar. nm -A dysplays all the symbols in an object file. if you grep for your sym and wc -l returns more than 1 line, the symbols has a reference, and can't be removed. Note it needs to be more than 1 line, as you have to account for the object defining the symbol Neil